Bug 8112

Summary: Wrong calculation of min/max values for time_t
Product: WebKit Reporter: Björn Graf (boki) <bjoern.graf>
Component: JavaScriptCoreAssignee: Nobody <webkit-unassigned>
Status: RESOLVED INVALID    
Severity: Normal CC: bugs-webkit, ian, webkit
Priority: P2    
Version: 420+   
Hardware: PC   
OS: Windows XP   
Bug Depends on:    
Bug Blocks: 3356    
Attachments:
Description Flags
Adds _USE_32BIT_TIME_T to the projects preprocessor definitions ggaren: review-

Björn Graf (boki)
Reported 2006-03-31 16:03:02 PST
In VC++ 2005 time_t defaults to time64_t which causes the calculation of the minimum and maximum values in millisecondsToTM to exceed _MAX_TIME64. A naive fix is to define _USE_32BIT_TIME_T.
Attachments
Adds _USE_32BIT_TIME_T to the projects preprocessor definitions (5.34 KB, patch)
2006-03-31 16:08 PST, Björn Graf (boki) 		ggaren: review-
DetailsFormatted DiffDiff
View All Add attachment proposed patch, testcase, etc.
Björn Graf (boki)
Comment 1 2006-03-31 16:08:22 PST
Created attachment 7426 [details] Adds _USE_32BIT_TIME_T to the projects preprocessor definitions This patch also changes the lib output directory to $(WebKitOutputDir)\$(ConfigurationName) and updates testkjs.vcproj to use the lib from that location. Winmm.lib is added for an upcoming StopWatch fix.
Geoffrey Garen
Comment 2 2006-03-31 16:18:46 PST
Comment on attachment 7426 [details] Adds _USE_32BIT_TIME_T to the projects preprocessor definitions Looks good. r=me
Eric Seidel (no email)
Comment 3 2006-04-04 04:58:42 PDT
This doesn't include a changelog entry and doesn't update the WebCore, ImageViewer or Spinneret targets, thus making it much harder to land. I'd rather you post a second patch instead.
Geoffrey Garen
Comment 4 2006-04-26 11:35:31 PDT
Comment on attachment 7426 [details] Adds _USE_32BIT_TIME_T to the projects preprocessor definitions Based on Eric's comments, I'm changing this to r-.
Eric Seidel (no email)
Comment 5 2007-09-30 11:01:42 PDT
This bug has been stale for over a year. The windows port works. :) Closing.
Note You need to log in before you can comment on or make changes to this bug.