Bug 81055

Summary: Heap::destroy leaks CopiedSpace
Product: WebKit Reporter: Mark Hahnenberg <mhahnenberg>
Component: JavaScriptCoreAssignee: Mark Hahnenberg <mhahnenberg>
Status: RESOLVED FIXED    
Severity: Normal CC: fpizlo, ggaren, levin+threading, webkit.review.bot
Priority: P2    
Version: 528+ (Nightly build)   
Hardware: Unspecified   
OS: Unspecified   
Attachments:
Description Flags
Patch ggaren: review+

Mark Hahnenberg
Reported 2012-03-13 16:27:06 PDT
Currently we do not do anything to clean up memory in the CopiedSpace in Heap::destroy. We should add a destroy() function to CopiedSpace to remedy this.
Attachments
Patch (3.41 KB, patch)
2012-03-13 18:07 PDT, Mark Hahnenberg 		ggaren: review+
DetailsFormatted DiffDiff
View All Add attachment proposed patch, testcase, etc.
Mark Hahnenberg
Comment 1 2012-03-13 16:27:22 PDT
<rdar://problem/11041460>
Mark Hahnenberg
Comment 2 2012-03-13 18:07:07 PDT
Created attachment 131766 [details] Patch
Geoffrey Garen
Comment 3 2012-03-14 12:39:58 PDT
Comment on attachment 131766 [details] Patch View in context: https://bugs.webkit.org/attachment.cgi?id=131766&action=review > Source/JavaScriptCore/heap/Heap.cpp:383 > + m_storageSpace.destroy(); This should move above the size() ASSERT.
Mark Hahnenberg
Comment 4 2012-03-14 14:14:28 PDT
Committed r110748: <http://trac.webkit.org/changeset/110748>
Note You need to log in before you can comment on or make changes to this bug.