| Summary: | Web Inspector: small improvement for HeapSnapshot performance ~12%. | ||||||
|---|---|---|---|---|---|---|---|
| Product: | WebKit | Reporter: | Ilya Tikhonovsky <loislo> | ||||
| Component: | Web Inspector (Deprecated) | Assignee: | Ilya Tikhonovsky <loislo> | ||||
| Status: | RESOLVED FIXED | ||||||
| Severity: | Normal | CC: | apavlov, bweinstein, joepeck, keishi, loislo, pfeldman, pmuellr, rik, timothy, yurys | ||||
| Priority: | P2 | ||||||
| Version: | 528+ (Nightly build) | ||||||
| Hardware: | All | ||||||
| OS: | All | ||||||
| Attachments: |
|
||||||
|
Description
Ilya Tikhonovsky
2012-03-13 13:51:35 PDT
Created attachment 131709 [details]
Patch
Comment on attachment 131709 [details] Patch View in context: https://bugs.webkit.org/attachment.cgi?id=131709&action=review > Source/WebCore/inspector/front-end/HeapSnapshot.js:1028 > + for (var i = 0; i < this.nodeCount; ++i) { Instead of replacing usages of the iterator can we change the iterator itself so that it works based on this.nodeIndexes array? (In reply to comment #2) > (From update of attachment 131709 [details]) > View in context: https://bugs.webkit.org/attachment.cgi?id=131709&action=review > > > Source/WebCore/inspector/front-end/HeapSnapshot.js:1028 > > + for (var i = 0; i < this.nodeCount; ++i) { > > Instead of replacing usages of the iterator can we change the iterator itself so that it works based on this.nodeIndexes array? It is too tricky to migrate this iterator to nodeIndex. I'd like to do this in separate patch. Committed r110698: <http://trac.webkit.org/changeset/110698> |