Bug 81033

Summary:

Web Inspector: small improvement for HeapSnapshot performance ~12%.

Product:

WebKit

Reporter:

Ilya Tikhonovsky <loislo>

Component:

Web Inspector (Deprecated)

Assignee:

Ilya Tikhonovsky <loislo>

Status:

RESOLVED FIXED

Severity:

Normal

CC:

apavlov, bweinstein, joepeck, keishi, loislo, pfeldman, pmuellr, rik, timothy, yurys

Priority:

Version:

528+ (Nightly build)

Hardware:

All

OS:

All

Attachments:

Description	Flags
Patch	yurys: review+

Ilya Tikhonovsky

Reported 2012-03-13 13:51:35 PDT

%subj%

Attachments
Patch (5.00 KB, patch) 2012-03-13 13:55 PDT, Ilya Tikhonovsky	yurys: review+	Details Formatted Diff Diff
View All Add attachment proposed patch, testcase, etc.

Ilya Tikhonovsky

Comment 1 2012-03-13 13:55:05 PDT

Created attachment 131709 [details] Patch

Yury Semikhatsky

Comment 2 2012-03-14 00:04:09 PDT

Comment on attachment 131709 [details] Patch View in context: https://bugs.webkit.org/attachment.cgi?id=131709&action=review > Source/WebCore/inspector/front-end/HeapSnapshot.js:1028 > + for (var i = 0; i < this.nodeCount; ++i) { Instead of replacing usages of the iterator can we change the iterator itself so that it works based on this.nodeIndexes array?

Ilya Tikhonovsky

Comment 3 2012-03-14 07:08:22 PDT

(In reply to comment #2) > (From update of attachment 131709 [details]) > View in context: https://bugs.webkit.org/attachment.cgi?id=131709&action=review > > > Source/WebCore/inspector/front-end/HeapSnapshot.js:1028 > > + for (var i = 0; i < this.nodeCount; ++i) { > > Instead of replacing usages of the iterator can we change the iterator itself so that it works based on this.nodeIndexes array? It is too tricky to migrate this iterator to nodeIndex. I'd like to do this in separate patch.

Ilya Tikhonovsky

Comment 4 2012-03-14 07:42:32 PDT

Committed r110698: <http://trac.webkit.org/changeset/110698>

Note You need to log in before you can comment on or make changes to this bug.