Bug 81029

Summary: css3/filters/custom/custom-filter-property-computed-style.html passes in browser, fails in DRT
Product: WebKit Reporter: Tim Horton <thorton>
Component: CSSAssignee: Nobody <webkit-unassigned>
Status: RESOLVED INVALID    
Severity: Normal CC: ap, dino, jberlin, krit, simon.fraser, webkit-bug-importer
Priority: P2 Keywords: InRadar, LayoutTestFailure
Version: 528+ (Nightly build)   
Hardware: Unspecified   
OS: Unspecified   
Attachments:
Description Flags
patch to land failing expectations none

Tim Horton
Reported 2012-03-13 13:26:36 PDT
Running this test in DRT, I see: Custom with vertex shader : custom(url(vertex.shader)) FAIL removeBaseURL(filterStyle.getPropertyValue('-webkit-filter')) should be custom(url(vertex.shader) none, 1 1 filter-box). Was none. FAIL jsWrapperClass(filterRule) should be CSSValueList. Was CSSPrimitiveValue. FAIL jsWrapperClass(filterRule.__proto__) should be CSSValueListPrototype. Was CSSPrimitiveValuePrototype. FAIL jsWrapperClass(filterRule.constructor) should be CSSValueListConstructor. Was CSSPrimitiveValueConstructor. FAIL filterRule.length should be 1 (of type number). Was undefined (of type undefined). FAIL subRule.operationType should be 12. Threw exception TypeError: 'undefined' is not an object (evaluating 'subRule.operationType') FAIL removeBaseURL(subRule.cssText) should be custom(url(vertex.shader) none, 1 1 filter-box). Threw exception TypeError: 'undefined' is not an object (evaluating 'subRule.cssText') etc. Running this test in Safari, I see: Custom with vertex shader : custom(url(vertex.shader)) PASS removeBaseURL(filterStyle.getPropertyValue('-webkit-filter')) is 'custom(url(vertex.shader) none, 1 1 filter-box)' PASS jsWrapperClass(filterRule) is 'CSSValueList' PASS jsWrapperClass(filterRule.__proto__) is 'CSSValueListPrototype' PASS jsWrapperClass(filterRule.constructor) is 'CSSValueListConstructor' PASS filterRule.length is 1 PASS subRule.operationType is WebKitCSSFilterValue.CSS_FILTER_CUSTOM PASS removeBaseURL(subRule.cssText) is 'custom(url(vertex.shader) none, 1 1 filter-box)' etc.
Attachments
patch to land failing expectations (20.58 KB, patch)
2012-03-13 13:49 PDT, Tim Horton
no flags
Radar WebKit Bug Importer
Comment 1 2012-03-13 13:27:32 PDT
Tim Horton
Comment 2 2012-03-13 13:49:12 PDT
Created attachment 131708 [details] patch to land failing expectations
Tim Horton
Comment 3 2012-03-13 13:50:14 PDT
TestFailures suggests it might be flaky; I've never seen it pass.
Tim Horton
Comment 4 2012-03-13 14:37:47 PDT
Landed failing results in http://trac.webkit.org/changeset/110612
Tim Horton
Comment 6 2012-03-13 18:40:19 PDT
(In reply to comment #5) > This either passes under WKTR, or is just flakey: > > http://build.webkit.org/results/Lion%20Intel%20Debug%20(WebKit2%20Tests)/r110645%20(4872)/css3/filters/custom/custom-filter-property-computed-style-pretty-diff.html Passing with WKTR and not DRT would vaguely match the fact that it passes in Safari (with WK2) and not DRT.
Tim Horton
Comment 7 2012-03-13 18:42:28 PDT
(In reply to comment #6) > (In reply to comment #5) > > This either passes under WKTR, or is just flakey: > > > > http://build.webkit.org/results/Lion%20Intel%20Debug%20(WebKit2%20Tests)/r110645%20(4872)/css3/filters/custom/custom-filter-property-computed-style-pretty-diff.html > > Passing with WKTR and not DRT would vaguely match the fact that it passes in Safari (with WK2) and not DRT. Nope, it passes in a WK1 Safari window too.
Jessie Berlin
Comment 8 2012-03-15 09:53:01 PDT
Landed expected passing results for mac-wk2 in http://trac.webkit.org/changeset/110855.
Note You need to log in before you can comment on or make changes to this bug.