Bug 81026

Summary:

migrate Yang Guo's expectations from chromium to webkit

Product:

WebKit

Reporter:

epoger

Component:

Tools / Tests

Assignee:

epoger

Status:

RESOLVED FIXED

Severity:

Normal

CC:

webkit.review.bot

Priority:

Version:

528+ (Nightly build)

Hardware:

Unspecified

OS:

Unspecified

Attachments:

Description	Flags
Patch	none
Patch	none
Patch	none
Patch	none

epoger

Reported 2012-03-13 12:59:38 PDT

Yang Guo had added some test expectations to chromium's "downstream" test_expectations.txt file. They need to be added to the "upstream" test_expectations.txt file (within the webkit repo) or else they will disappear at Chromium's next WebKit roll.

Attachments
Patch (1.64 KB, patch) 2012-03-13 14:11 PDT, epoger	no flags	Details Formatted Diff Diff
Patch (1.65 KB, patch) 2012-03-13 14:16 PDT, epoger	no flags	Details Formatted Diff Diff
Patch (1.68 KB, patch) 2012-03-14 08:35 PDT, epoger	no flags	Details Formatted Diff Diff
Patch (1.65 KB, patch) 2012-03-14 11:05 PDT, epoger	no flags	Details Formatted Diff Diff
Show Obsolete (3) View All Add attachment proposed patch, testcase, etc.

epoger

Comment 1 2012-03-13 14:11:33 PDT

Created attachment 131711 [details] Patch

WebKit Review Bot

Comment 2 2012-03-13 14:14:45 PDT

Attachment 131711 [details] did not pass style-queue: Failed to run "['Tools/Scripts/check-webkit-style', '--diff-files', u'LayoutTests/ChangeLog', u'LayoutTests/plat..." exit_code: 1 LayoutTests/ChangeLog:6: Line contains tab character. [whitespace/tab] [5] Total errors found: 1 in 2 files If any of these errors are false positives, please file a bug against check-webkit-style.

epoger

Comment 3 2012-03-13 14:16:42 PDT

Created attachment 131712 [details] Patch

epoger

Comment 4 2012-03-13 14:18:05 PDT

Unless anyone objects, I will get this committed Wednesday morning (US East Coast time).

epoger

Comment 5 2012-03-14 08:35:38 PDT

Created attachment 131858 [details] Patch

epoger

Comment 6 2012-03-14 11:05:33 PDT

Created attachment 131884 [details] Patch