Bug 81007

Summary:

check-webkit-style fails on LayoutTests/platform/efl/test_expectations.txt

Product:

WebKit

Reporter:

Kishore Bolisetty <kbolisetty>

Component:

Tools / Tests

Assignee:

Nobody <webkit-unassigned>

Status:

RESOLVED FIXED

Severity:

Normal

CC:

abarth, gyuyoung.kim, jchaffraix, mrahaman, ojan, webkit.review.bot

Priority:

Version:

528+ (Nightly build)

Hardware:

Unspecified

OS:

Unspecified

Attachments:

Description	Flags
patch	none

Kishore Bolisetty

Reported 2012-03-13 09:57:56 PDT

./Tools/Scripts/check-webkit-style LayoutTests/platform/efl/test_expectations.txt fails even after removing duplicate entries in Skipped & test_expectations.txt ./Tools/Scripts/check-webkit-style LayoutTests/platform/efl/test_expectations.txt Traceback (most recent call last): File "./Tools/Scripts/check-webkit-style", line 48, in <module> sys.exit(CheckWebKitStyle().main()) File "/home/administrator/kishore/osc/code/8march/WebKit/Tools/Scripts/webkitpy/style/main.py", line 149, in main file_reader.process_paths(paths) File "/home/administrator/kishore/osc/code/8march/WebKit/Tools/Scripts/webkitpy/style/filereader.py", line 145, in process_paths self.process_file(path) File "/home/administrator/kishore/osc/code/8march/WebKit/Tools/Scripts/webkitpy/style/filereader.py", line 130, in process_file self._processor.process(lines, file_path, **kwargs) File "/home/administrator/kishore/osc/code/8march/WebKit/Tools/Scripts/webkitpy/style/checker.py", line 838, in process checker.check(lines) File "/home/administrator/kishore/osc/code/8march/WebKit/Tools/Scripts/webkitpy/style/checkers/test_expectations.py", line 103, in check overrides = self._port_obj.test_expectations_overrides() AttributeError: 'NoneType' object has no attribute 'test_expectations_overrides'

Attachments
patch (1.56 KB, patch) 2012-03-15 22:46 PDT, Kishore Bolisetty	no flags	Details Formatted Diff Diff
View All Add attachment proposed patch, testcase, etc.

Kishore Bolisetty

Comment 1 2012-03-13 10:05:02 PDT

I also have done little debugging in python scripts and could find the workaround for this issue, but not sure if it is a right fix. Adding "efl" in Tools/Scripts/webkitpy/layout_tests/port/builders.py as shown below would solve the issue. _ports_without_builders = [ "google-chrome-linux32", "google-chrome-linux64", "qt-mac", "qt-win", "qt-wk2", "efl", ]

Kishore Bolisetty

Comment 2 2012-03-15 22:46:06 PDT

Created attachment 132200 [details] patch

WebKit Review Bot

Comment 3 2012-03-16 05:14:50 PDT

Comment on attachment 132200 [details] patch Clearing flags on attachment: 132200 Committed r110990: <http://trac.webkit.org/changeset/110990>

WebKit Review Bot

Comment 4 2012-03-16 05:14:57 PDT

All reviewed patches have been landed. Closing bug.

Note You need to log in before you can comment on or make changes to this bug.