Bug 81003

Summary: Feature: keep track of whether FormData's and WebHTTPBody's contain passwords
Product: WebKit Reporter: Marja Hölttä <marja>
Component: FormsAssignee: Marja Hölttä <marja>
Status: RESOLVED FIXED    
Severity: Normal CC: abarth, fishd, japhet, jochen, webkit.review.bot
Priority: P2    
Version: 528+ (Nightly build)   
Hardware: All   
OS: All   
Attachments:
Description Flags
Patch.
none
Patch.
none
Patch. none

Marja Hölttä
Reported 2012-03-13 09:16:30 PDT
Chrome is saving and restoring navigation entries to continue the browsing session. We would like to remove the POSTed data from the navigation entry before saving it, *if* the HTTP body has passwords in it. I'll attach a patch for keeping track of whether FormData and WebHTTPBody contain data from password fields.
Attachments
Patch. (4.94 KB, patch)
2012-03-13 09:46 PDT, Marja Hölttä 		no flags
DetailsFormatted DiffDiff
Patch. (7.18 KB, patch)
2012-03-13 10:37 PDT, Marja Hölttä 		no flags
DetailsFormatted DiffDiff
Patch. (7.25 KB, patch)
2012-03-14 03:38 PDT, Marja Hölttä 		no flags
DetailsFormatted DiffDiff
Show Obsolete (2) View All Add attachment proposed patch, testcase, etc.
Marja Hölttä
Comment 1 2012-03-13 09:46:50 PDT
Created attachment 131642 [details] Patch.
WebKit Review Bot
Comment 2 2012-03-13 09:50:26 PDT
Please wait for approval from fishd@chromium.org before submitting because this patch contains changes to the Chromium public API.
Marja Hölttä
Comment 3 2012-03-13 10:37:30 PDT
Created attachment 131661 [details] Patch.
WebKit Review Bot
Comment 4 2012-03-13 10:40:28 PDT
Attachment 131661 [details] did not pass style-queue: Failed to run "['Tools/Scripts/check-webkit-style', '--diff-files', u'Source/WebCore/ChangeLog', u'Source/WebCor..." exit_code: 1 Source/WebKit/chromium/ChangeLog:1: ChangeLog entry has no bug number [changelog/bugnumber] [5] Source/WebCore/ChangeLog:1: ChangeLog entry has no bug number [changelog/bugnumber] [5] Source/WebCore/ChangeLog:7: You should remove the 'No new tests' and either add and list tests, or explain why no new tests were possible. [changelog/nonewtests] [5] Total errors found: 3 in 7 files If any of these errors are false positives, please file a bug against check-webkit-style.
Darin Fisher (:fishd, Google)
Comment 5 2012-03-13 12:36:17 PDT
Comment on attachment 131661 [details] Patch. R=me, but please fix style errors before landing. I'd like to review the corresponding glue_serialize.cc changes as well.
Marja Hölttä
Comment 6 2012-03-14 03:38:45 PDT
Created attachment 131820 [details] Patch.
WebKit Review Bot
Comment 7 2012-03-14 05:41:51 PDT
Comment on attachment 131820 [details] Patch. Clearing flags on attachment: 131820 Committed r110695: <http://trac.webkit.org/changeset/110695>
WebKit Review Bot
Comment 8 2012-03-14 05:41:56 PDT
All reviewed patches have been landed. Closing bug.
Note You need to log in before you can comment on or make changes to this bug.