Summary: | Web Inspector: add didCancelFrame timeline event | ||||||||||||
---|---|---|---|---|---|---|---|---|---|---|---|---|---|
Product: | WebKit | Reporter: | Andrey Kosyakov <caseq> | ||||||||||
Component: | Web Inspector (Deprecated) | Assignee: | Andrey Kosyakov <caseq> | ||||||||||
Status: | RESOLVED FIXED | ||||||||||||
Severity: | Normal | CC: | abarth, apavlov, bweinstein, fishd, gustavo.noronha, gustavo, joepeck, keishi, loislo, pfeldman, pmuellr, rik, timothy, webkit.review.bot, xan.lopez, yurys | ||||||||||
Priority: | P2 | ||||||||||||
Version: | 528+ (Nightly build) | ||||||||||||
Hardware: | All | ||||||||||||
OS: | All | ||||||||||||
Attachments: |
|
Description
Andrey Kosyakov
2012-03-13 08:53:28 PDT
Created attachment 131628 [details]
Patch
Please wait for approval from fishd@chromium.org before submitting because this patch contains changes to the Chromium public API. Comment on attachment 131628 [details]
Patch
Please provide a test.
Created attachment 131671 [details]
Patch
Created attachment 131676 [details]
Patch
Comment on attachment 131671 [details] Patch View in context: https://bugs.webkit.org/attachment.cgi?id=131671&action=review Overall looks good, a bunch of nits to be fixed prior to landing. > Source/WebCore/ChangeLog:6 > + Reviewed by NOBODY (OOPS!). Could you generate fresh ChangeLogs? > Source/WebCore/inspector/InspectorTimelineAgent.cpp:177 > + pushCancellableRecord(InspectorObject::create(), TimelineRecordType::BeginFrame); "Cancelable" ? > Source/WebCore/inspector/InspectorTimelineAgent.cpp:423 > entry.record->setArray("children", entry.children); You should move children to under the cancelable as well. > Source/WebCore/inspector/InspectorTimelineAgent.cpp:466 > + didCompleteCurrentRecord(m_recordStack.last().type); didCompleteCurrentRecord is not applicable to atomic events, you should do appendRecord instead. I am not sure you even need a stack for them. > Source/WebCore/testing/Internals.cpp:676 > +void Internals::emitTimelineDidBeginFrame() emitInspectorDidBeginFrame ? Comment on attachment 131671 [details] Patch Attachment 131671 [details] did not pass mac-ews (mac): Output: http://queues.webkit.org/results/11942659 Comment on attachment 131671 [details] Patch Attachment 131671 [details] did not pass gtk-ews (gtk): Output: http://queues.webkit.org/results/11947774 Comment on attachment 131671 [details] Patch Attachment 131671 [details] did not pass gtk-ews (gtk): Output: http://queues.webkit.org/results/11945747 Created attachment 131813 [details]
Patch
Comment on attachment 131813 [details] Patch View in context: https://bugs.webkit.org/attachment.cgi?id=131813&action=review > Source/WebCore/inspector/InspectorTimelineAgent.cpp:459 > + m_recordStack.append(TimelineRecordEntry(record.release(), data, InspectorArray::create(), type, true)); I'd be great if we could make this children array nullable. Comment on attachment 131813 [details] Patch Attachment 131813 [details] did not pass gtk-ews (gtk): Output: http://queues.webkit.org/results/11949926 Comment on attachment 131813 [details] Patch Attachment 131813 [details] did not pass win-ews (win): Output: http://queues.webkit.org/results/11949938 Committed r110706: <http://trac.webkit.org/changeset/110706> |