Summary: | Separate NOTIFICATIONS and LEGACY_NOTIFICATIONS | ||||||||||||
---|---|---|---|---|---|---|---|---|---|---|---|---|---|
Product: | WebKit | Reporter: | Jon Lee <jonlee> | ||||||||||
Component: | New Bugs | Assignee: | Jon Lee <jonlee> | ||||||||||
Status: | RESOLVED FIXED | ||||||||||||
Severity: | Normal | CC: | abarth, eoconnor, haraken, japhet, mike, mjs, ojan, rakuco, sam, tkent, webkit-bug-importer, webkit.review.bot, yael | ||||||||||
Priority: | P2 | Keywords: | InRadar | ||||||||||
Version: | 528+ (Nightly build) | ||||||||||||
Hardware: | All | ||||||||||||
OS: | All | ||||||||||||
Bug Depends on: | |||||||||||||
Bug Blocks: | 80472 | ||||||||||||
Attachments: |
|
Description
Jon Lee
2012-03-12 18:28:50 PDT
Created attachment 131724 [details]
Patch
Also, with this patch, the generated files look like such: In EventTargetFactory.in, this line: Notification conditional=NOTIFICATIONS|LEGACY_NOTIFICATIONS generates in EventTargetHeaders.h: #if ENABLE(NOTIFICATIONS) || ENABLE(LEGACY_NOTIFICATIONS) #include "Notification.h" #if USE(JSC) #include "JSNotification.h" #elif USE(V8) #include "V8Notification.h" #endif and in EventTargetInterfaces.h: #if ENABLE(NOTIFICATIONS) || ENABLE(LEGACY_NOTIFICATIONS) #define DOM_EVENT_TARGET_INTERFACES_FOR_EACH_NOTIFICATIONS(macro) \ macro(Notification) \ // End of DOM_EVENT_TARGET_INTERFACES_FOR_EACH_NOTIFICATIONS #else #define DOM_EVENT_TARGET_INTERFACES_FOR_EACH_NOTIFICATIONS(macro) #endif ... #define DOM_EVENT_TARGET_INTERFACES_FOR_EACH(macro) \ ... DOM_EVENT_TARGET_INTERFACES_FOR_EACH_NOTIFICATIONS(macro) \ ... Created attachment 131744 [details]
Patch
Created attachment 131745 [details]
Patch rebase
Comment on attachment 131745 [details] Patch rebase Attachment 131745 [details] did not pass mac-ews (mac): Output: http://queues.webkit.org/results/11944876 Created attachment 131795 [details]
Same patch again, to go through mac ews
Comment on attachment 131795 [details] Same patch again, to go through mac ews View in context: https://bugs.webkit.org/attachment.cgi?id=131795&action=review > Source/WebCore/bindings/scripts/InFilesCompiler.pm:174 > + my @conditionals = split('\\|', $conditional); It seems that we only handle '|', not '&' here. But since handling of '&' is not required for this patch, you should consider it in another patch or ask Adam to enhance it. > Source/WebCore/bindings/scripts/InFilesCompiler.pm:224 > + Remove empty line. (In reply to comment #8) > (From update of attachment 131795 [details]) > View in context: https://bugs.webkit.org/attachment.cgi?id=131795&action=review > > > Source/WebCore/bindings/scripts/InFilesCompiler.pm:174 > > + my @conditionals = split('\\|', $conditional); > > It seems that we only handle '|', not '&' here. But since handling of '&' is not required for this patch, you should consider it in another patch or ask Adam to enhance it. Bug 81169 > > > Source/WebCore/bindings/scripts/InFilesCompiler.pm:224 > > + > > Remove empty line. Done. Thanks! Committed r110784: <http://trac.webkit.org/changeset/110784> |