| Summary: | [chromium] vsync ticks are needed in invisible tabs when we are still updating resources | ||||||
|---|---|---|---|---|---|---|---|
| Product: | WebKit | Reporter: | Nat Duca <nduca> | ||||
| Component: | New Bugs | Assignee: | Nat Duca <nduca> | ||||
| Status: | RESOLVED FIXED | ||||||
| Severity: | Normal | CC: | cc-bugs, husky, jamesr, webkit.review.bot | ||||
| Priority: | P2 | ||||||
| Version: | 528+ (Nightly build) | ||||||
| Hardware: | Unspecified | ||||||
| OS: | Unspecified | ||||||
| Attachments: |
|
||||||
|
Description
Nat Duca
2012-03-12 17:23:11 PDT
Created attachment 131464 [details]
Patch
When we go in the background to another tab just before we begin a frame and commit, and there are more updates than can fit in a frame, then we forget to tick the scheduler. This leaves us the main thread blocked in the commit. *** Bug 80995 has been marked as a duplicate of this bug. *** Confirmed that this patch fixes the bug for me. Comment on attachment 131464 [details]
Patch
R=me
I think it would be useful to have a way to abort pending updates as well when going !visible or when dropping resources, so we don't upload until tiles that we wanna drop or have already dropped.
(In reply to comment #5) > I think it would be useful to have a way to abort pending updates as well when going !visible or when dropping resources, so we don't upload until tiles that we wanna drop or have already dropped. Or, maybe we can make the updates just skip --- e.g. we do the update step but early out the individual updates if they're discovered to be pointless. That'd allow us to speed through the update step if we were trying to drop command buffer resources, but still always drop the command buffer resources in a consistent place [COMMIT_IDLE]. Comment on attachment 131464 [details] Patch Clearing flags on attachment: 131464 Committed r110627: <http://trac.webkit.org/changeset/110627> All reviewed patches have been landed. Closing bug. |