Bug 80892

Summary: [Skia] Release CGImage used to apply color space conversion to SkBitmap
Product: WebKit Reporter: Brian Salomon <bsalomon>
Component: PlatformAssignee: Brian Salomon <bsalomon>
Status: RESOLVED FIXED    
Severity: Normal CC: abarth, senorblanco, webkit.review.bot
Priority: P2    
Version: 528+ (Nightly build)   
Hardware: Mac   
OS: All   
Attachments:
Description Flags
Patch none

Brian Salomon
Reported 2012-03-12 14:39:11 PDT
Release CGImage used to apply color space conversion to SkBitmap
Attachments
Patch (2.00 KB, patch)
2012-03-12 14:43 PDT, Brian Salomon 		no flags
DetailsFormatted DiffDiff
View All Add attachment proposed patch, testcase, etc.
Brian Salomon
Comment 1 2012-03-12 14:43:00 PDT
Created attachment 131415 [details] Patch
Brian Salomon
Comment 2 2012-03-12 14:44:50 PDT
This fixes a pretty bad memory leak on the mac. Any decoded image that has a color space conversion applied is leaked. Cary Clark (who wrote the relevant function) confirmed that there is a leak and the fix is to release the CGImageRef.
Brian Salomon
Comment 3 2012-03-12 14:50:23 PDT
Associated CR bug: http://crbug.com/117011
Adam Barth
Comment 4 2012-03-12 16:24:00 PDT
Comment on attachment 131415 [details] Patch Clearing flags on attachment: 131415 Committed r110499: <http://trac.webkit.org/changeset/110499>
Adam Barth
Comment 5 2012-03-12 16:24:04 PDT
All reviewed patches have been landed. Closing bug.
Note You need to log in before you can comment on or make changes to this bug.