Bug 80892

Summary:

[Skia] Release CGImage used to apply color space conversion to SkBitmap

Product:

WebKit

Reporter:

Brian Salomon <bsalomon>

Component:

Platform

Assignee:

Brian Salomon <bsalomon>

Status:

RESOLVED FIXED

Severity:

Normal

CC:

abarth, senorblanco, webkit.review.bot

Priority:

Version:

528+ (Nightly build)

Hardware:

Mac

OS:

All

Attachments:

Description	Flags
Patch	none

Description Brian Salomon 2012-03-12 14:39:11 PDT

Release CGImage used to apply color space conversion to SkBitmap

Comment 1 Brian Salomon 2012-03-12 14:43:00 PDT

Created attachment 131415 [details]
Patch

Comment 2 Brian Salomon 2012-03-12 14:44:50 PDT

This fixes a pretty bad memory leak on the mac. Any decoded image that has a color space conversion applied is leaked. Cary Clark (who wrote the relevant function) confirmed that there is a leak and the fix is to release the CGImageRef.

Comment 3 Brian Salomon 2012-03-12 14:50:23 PDT

Associated CR bug: http://crbug.com/117011

Comment 4 Adam Barth 2012-03-12 16:24:00 PDT

Comment on attachment 131415 [details]
Patch

Clearing flags on attachment: 131415

Committed r110499: <http://trac.webkit.org/changeset/110499>

Comment 5 Adam Barth 2012-03-12 16:24:04 PDT

All reviewed patches have been landed.  Closing bug.