Implement proper sub-pixel support in RenderFileUploadControl

• Component: Layout and Rendering
• Status: RESOLVED FIXED

[Levi Weintraub]

We currently do some improper truncating and promoting of LayoutUnits to floats without pixel snapping in RenderFileUploadControl.

[Levi Weintraub]

Created attachment 131406 [details]
Patch

[Emil A Eklund]

Comment on attachment 131406 [details]
Patch

View in context: https://bugs.webkit.org/attachment.cgi?id=131406&action=review

> Source/WebCore/rendering/RenderFileUploadControl.cpp:107
> +        IntRect clipRect = pixelSnappedIntRect(LayoutRect(paintOffset.x() + borderLeft(), paintOffset.y() + borderTop(),

Isn't there a pixelSnappedIntRect implementation that takes x, y, w, h? Seems better than creating a LayoutRect and then immediately snapping it.

> Source/WebCore/rendering/RenderFileUploadControl.cpp:157
> +            input->icon()->paint(paintInfo.context, IntRect(roundedIntPoint(LayoutPoint(iconX, iconY)), IntSize(iconWidth, iconHeight)));

IntRect(iconX.round(), iconY.round(), iconWidth, iconHeight) seems easier.

[Levi Weintraub]

Created attachment 131413 [details]
Patch

[Emil A Eklund]

Looks good, thanks!

[Levi Weintraub]

Any takers on a review?

[Dimitri Glazkov (Google)]

Comment on attachment 131413 [details]
Patch

ok

[Levi Weintraub]

Comment on attachment 131413 [details]
Patch

Thanks for the review, Mr. Glazkov :)

[WebKit Review Bot]

Comment on attachment 131413 [details]
Patch

Clearing flags on attachment: 131413

Committed r110761: <http://trac.webkit.org/changeset/110761>

[WebKit Review Bot]

All reviewed patches have been landed.  Closing bug.