Summary: | REGRESSION: Repro crash when dragging to select over a new text field | ||||||||
---|---|---|---|---|---|---|---|---|---|
Product: | WebKit | Reporter: | mitz | ||||||
Component: | Forms | Assignee: | Nobody <webkit-unassigned> | ||||||
Status: | VERIFIED FIXED | ||||||||
Severity: | Normal | CC: | adele, justin.garcia | ||||||
Priority: | P1 | Keywords: | Regression | ||||||
Version: | 420+ | ||||||||
Hardware: | Mac | ||||||||
OS: | OS X 10.4 | ||||||||
Attachments: |
|
Description
mitz
2006-03-30 09:38:48 PST
Created attachment 7396 [details]
Test case (crasher)
I'm guess: adjustForEditableContent finds that the extent is in a different root editable element than the base (the extent is inside a textfield and the base is not), then it tries to climb out of the the extent root in order to change the extent to the first visible position after the extent root. But it can't climb out of extent root because it's a shadow node. Created attachment 7398 [details]
patch
Comment on attachment 7398 [details]
patch
Justin - do we need to worry about this for the base node?
Comment on attachment 7398 [details]
patch
adele & i talked about this and she's going to add a similar piece of code for the case where the selection starts in editable content. we also talked about how we this fix doesn't work if an editable shadow node was inside another editable shadow node. she could just put this adjustment inside the do {} loop and both cases would be fixed.
|