Bug 80824

Summary:

Node::op and Node::flags should be private

Product:

WebKit

Reporter:

Filip Pizlo <fpizlo>

Component:

JavaScriptCore

Assignee:

Nobody <webkit-unassigned>

Status:

RESOLVED FIXED

Severity:

Normal

CC:

rakuco, webkit.review.bot

Priority:

Keywords:

InRadar

Version:

528+ (Nightly build)

Hardware:

All

OS:

All

Bug Depends on:

80779

Bug Blocks:

80819

Attachments:

Description	Flags
the patch	barraclough: review+

Description Filip Pizlo 2012-03-12 01:49:45 PDT

Patch forthcoming.

Comment 1 Filip Pizlo 2012-03-12 14:17:13 PDT

Created attachment 131407 [details]
the patch

Comment 2 WebKit Review Bot 2012-03-12 14:22:14 PDT

Attachment 131407 [details] did not pass style-queue:

Failed to run "['Tools/Scripts/check-webkit-style', '--diff-files', u'Source/JavaScriptCore/CMakeLists.txt', u'S..." exit_code: 1
Source/JavaScriptCore/dfg/DFGNodeType.h:207:  Non-label code inside switch statements should be indented.  [whitespace/indent] [4]
Total errors found: 1 in 23 files


If any of these errors are false positives, please file a bug against check-webkit-style.

Comment 3 Filip Pizlo 2012-03-12 15:32:20 PDT

<rdar://problem/11033435>

Comment 4 Filip Pizlo 2012-03-12 16:16:19 PDT

Landed in http://trac.webkit.org/changeset/110498