Bug 8081

Summary: REGRESSION: Drop-down menu has gap at top
Product: WebKit Reporter: John Muccigrosso <internetj>
Component: Layout and RenderingAssignee: Nobody <webkit-unassigned>
Status: RESOLVED FIXED    
Severity: Normal CC: mitz
Priority: P1 Keywords: InRadar, Regression
Version: 420+   
Hardware: Mac   
OS: OS X 10.4   
URL: http://drew.edu
Attachments:
Description Flags
Reduction without problem
none
Reduction
none
Further reduction
none
Proposed patch darin: review+

John Muccigrosso
Reported 2006-03-30 09:17:02 PST
Mousing over green items at top center of page produces a drop-down menu which has a gap between the text and the first item in the drop-down menu, which is otherwise complete.
Attachments
Reduction without problem (15.61 KB, text/html)
2006-03-30 09:17 PST, John Muccigrosso 		no flags
Details
Reduction (15.59 KB, text/html)
2006-03-30 09:19 PST, John Muccigrosso 		no flags
Details
Further reduction (389 bytes, text/html)
2006-03-30 13:37 PST, mitz 		no flags
Details
Proposed patch (6.11 KB, patch)
2006-03-30 15:02 PST, mitz 		darin: review+
DetailsFormatted DiffDiff
View All Add attachment proposed patch, testcase, etc.
John Muccigrosso
Comment 1 2006-03-30 09:17:48 PST
Created attachment 7394 [details] Reduction without problem Commented out most of original document
John Muccigrosso
Comment 2 2006-03-30 09:18:43 PST
Comment on attachment 7394 [details] Reduction without problem Made an additional change to reduction to eliminate bug.
John Muccigrosso
Comment 3 2006-03-30 09:19:14 PST
Created attachment 7395 [details] Reduction Commented out extraneous scripts and text.
mitz
Comment 4 2006-03-30 09:42:17 PST
Confirmed. This is a regression in TOT.
mitz
Comment 5 2006-03-30 13:37:11 PST
Created attachment 7404 [details] Further reduction
mitz
Comment 6 2006-03-30 13:41:15 PST
Comment on attachment 7404 [details] Further reduction Forgot to say that this should look like a green square with a 1px red border. The absolutely-positioned block seems to add up the height of the rows above its row twice.
mitz
Comment 7 2006-03-30 15:02:11 PST
Created attachment 7407 [details] Proposed patch
Darin Adler
Comment 8 2006-03-30 20:53:38 PST
Comment on attachment 7407 [details] Proposed patch Is this the only place that needs an isTableRow() check like this? Is there a better way to write the check than isTableRow()? r=me
Beth Dakin
Comment 9 2006-03-31 11:14:32 PST
I committed this fix. Also, this same problem is in Radar as <rdar://problem/4496510>
Note You need to log in before you can comment on or make changes to this bug.