Bug 80778

Summary: Null argument to texSubImage2D crashes
Product: WebKit Reporter: Kenneth Russell <kbr>
Component: WebGLAssignee: Kenneth Russell <kbr>
Status: RESOLVED FIXED    
Severity: Normal CC: dino, jamesr, senorblanco, twiz, webkit.review.bot, zmo
Priority: P1    
Version: 528+ (Nightly build)   
Hardware: All   
OS: All   
Attachments:
Description Flags
Patch none

Kenneth Russell
Reported 2012-03-10 21:24:32 PST
Passing null to the texSubImage2D variant taking ArrayBufferData causes a crash in both Safari and Chromium. At one point the intent of the code was to generate an INVALID_VALUE OpenGL error, but at some point this regressed. It also isn't tested by the WebGL conformance tests. The exact behavior is still being discussed on the public_webgl mailing list but minimally the code should be patched immediately to avoid crashing.
Attachments
Patch (7.51 KB, patch)
2012-03-12 12:00 PDT, Kenneth Russell 		no flags
DetailsFormatted DiffDiff
View All Add attachment proposed patch, testcase, etc.
Zhenyao Mo
Comment 1 2012-03-12 10:23:53 PDT
I'll patch it to generate INVALID_ERROR for now.
Kenneth Russell
Comment 2 2012-03-12 12:00:54 PDT
Created attachment 131374 [details] Patch
Kenneth Russell
Comment 3 2012-03-12 12:01:36 PDT
Oops, Mo, sorry, I didn't see you had taken this. Feel free to use or ignore the attached patch.
Zhenyao Mo
Comment 4 2012-03-12 12:50:41 PDT
The patch looks good. Assigning to kbr.
Dean Jackson
Comment 5 2012-03-12 14:06:59 PDT
Comment on attachment 131374 [details] Patch Thanks.
WebKit Review Bot
Comment 6 2012-03-12 14:59:33 PDT
Comment on attachment 131374 [details] Patch Clearing flags on attachment: 131374 Committed r110485: <http://trac.webkit.org/changeset/110485>
WebKit Review Bot
Comment 7 2012-03-12 14:59:38 PDT
All reviewed patches have been landed. Closing bug.
Note You need to log in before you can comment on or make changes to this bug.