Bug 80762 – VCSUtils.pm doesn't support SVN 1.7 diff files

• Component: Tools / Tests
• Status: RESOLVED FIXED

[Ashod Nakashian]

VCSUtils.pm doesn't support SVN 1.7 diff files. In particular, SVN properties aren't completely supported and the 1.7 version specific markers aren't supported at all.

This bug is to address this issue, adding support for SVN 1.7 diff files as much as reasonably possible. Specifically, the following FIXME in VCSUtils.pm:1007 is to be addressed:


        # FIXME: We should expand this code to support other properties.  In the future,
        #        parseSvnDiffProperties may return a hash whose keys are the properties.

[Daniel Bates]

Created attachment 167692 [details]
Patch and unit tests

[Eric Seidel (no email)]

Comment on attachment 167692 [details]
Patch and unit tests

Seems reasonable to me, but I feel neither a perl nor svn expert.  If you need a more detailed review, I recommend you find one. :)

[Daniel Bates]

(In reply to comment #0)
> [...]
> This bug is to address this issue, adding support for SVN 1.7 diff files as much as reasonably possible. Specifically, the following FIXME in VCSUtils.pm:1007 is to be addressed:
> 
> 
>         # FIXME: We should expand this code to support other properties.  In the future,
>         #        parseSvnDiffProperties may return a hash whose keys are the properties.

This FIXME is to implement support for recognizing additional SVN properties (*). It isn't necessary to fix this FIXME to support SVN 1.7 formatted diffs. Filed <https://bugs.webkit.org/show_bug.cgi?id=98723> to recognize additional SVN properties.

(*) Currently, we only recognize the property svn:executable.

[Daniel Bates]

*** Bug 80104 has been marked as a duplicate of this bug. ***

[Daniel Bates]

Comment on attachment 167692 [details]
Patch and unit tests

Clearing flags on attachment: 167692

Committed r130805: <http://trac.webkit.org/changeset/130805>

[Daniel Bates]

All reviewed patches have been landed.  Closing bug.