Bug 80657

Summary: Separate WTF parts of JavaScriptCoreGenerated into WTFGenerated for Windows build
Product: WebKit Reporter: Steve Falkenburg <sfalken>
Component: New BugsAssignee: Steve Falkenburg <sfalken>
Status: RESOLVED FIXED    
Severity: Normal CC: bfulgham, eric, jberlin
Priority: P2    
Version: 528+ (Nightly build)   
Hardware: Unspecified   
OS: Unspecified   
Bug Depends on:    
Bug Blocks: 75673    
Attachments:
Description Flags
Patch jberlin: review+

Steve Falkenburg
Reported 2012-03-08 17:12:04 PST
Separate WTF parts of JavaScriptCoreGenerated into WTFGenerated for Windows build
Attachments
Patch (97.54 KB, patch)
2012-03-08 17:20 PST, Steve Falkenburg 		jberlin: review+
DetailsFormatted DiffDiff
View All Add attachment proposed patch, testcase, etc.
Steve Falkenburg
Comment 1 2012-03-08 17:20:19 PST
Created attachment 130941 [details] Patch
Jessie Berlin
Comment 2 2012-03-08 17:54:50 PST
Comment on attachment 130941 [details] Patch View in context: https://bugs.webkit.org/attachment.cgi?id=130941&action=review r=me. Hopefully bfulgham will get a chance to take a look at it before you commit it. > Source/JavaScriptCore/JavaScriptCore.vcproj/JavaScriptCore/JavaScriptCoreGenerated.vcproj:34 > + CompileAsManaged="" Do we know why this section got added? It looks like it got pulled into the vcproj from the JavaScriptCoreGeneratedCommon.vsprops file. I think the addition of this sections should probably be reverted. Otherwise, future changes to the vsprops files might not have any effect. > Source/JavaScriptCore/JavaScriptCore.vcproj/JavaScriptCore/JavaScriptCoreGenerated.vcproj:53 > + CompileAsManaged="" Ditto. > Source/JavaScriptCore/JavaScriptCore.vcproj/JavaScriptCore/JavaScriptCoreGenerated.vcproj:72 > + CompileAsManaged="" Ditto. > Source/JavaScriptCore/JavaScriptCore.vcproj/JavaScriptCore/JavaScriptCoreGenerated.vcproj:91 > + CompileAsManaged="" Ditto. > Source/JavaScriptCore/JavaScriptCore.vcproj/JavaScriptCore/JavaScriptCoreGenerated.vcproj:110 > + CompileAsManaged="" Ditto. > Source/JavaScriptCore/JavaScriptCore.vcproj/JavaScriptCore/JavaScriptCoreGenerated.vcproj:129 > + CompileAsManaged="" Ditto. > Source/JavaScriptCore/JavaScriptCore.vcproj/JavaScriptCore/JavaScriptCoreGenerated.vcproj:148 > + CompileAsManaged="" Ditto. > Source/JavaScriptCore/JavaScriptCore.vcproj/WTF/WTFGenerated.vcproj:34 > + CompileAsManaged="" I think the same goes for this section. It looks like it is covered by the WTFGeneratedCommon.vsprops. > Source/JavaScriptCore/JavaScriptCore.vcproj/WTF/WTFGenerated.vcproj:53 > + CompileAsManaged="" Ditto. > Source/JavaScriptCore/JavaScriptCore.vcproj/WTF/WTFGenerated.vcproj:72 > + CompileAsManaged="" Ditto. > Source/JavaScriptCore/JavaScriptCore.vcproj/WTF/WTFGenerated.vcproj:91 > + CompileAsManaged="" Ditto. > Source/JavaScriptCore/JavaScriptCore.vcproj/WTF/WTFGenerated.vcproj:110 > + CompileAsManaged="" Ditto. > Source/JavaScriptCore/JavaScriptCore.vcproj/WTF/WTFGenerated.vcproj:129 > + CompileAsManaged="" Ditto.
Eric Seidel (no email)
Comment 3 2012-03-08 20:11:16 PST
Yay! Thanks. No way I could have done this (safely) myself. :)
Steve Falkenburg
Comment 4 2012-03-08 22:07:24 PST
Comment on attachment 130941 [details] Patch View in context: https://bugs.webkit.org/attachment.cgi?id=130941&action=review >> Source/JavaScriptCore/JavaScriptCore.vcproj/JavaScriptCore/JavaScriptCoreGenerated.vcproj:34 >> + CompileAsManaged="" > > Do we know why this section got added? It looks like it got pulled into the vcproj from the JavaScriptCoreGeneratedCommon.vsprops file. > > I think the addition of this sections should probably be reverted. Otherwise, future changes to the vsprops files might not have any effect. Wow - you're right. Looks like Visual Studio copied these from the vsprops into the vcproj. I'll revert these changes.
Steve Falkenburg
Comment 5 2012-03-08 22:20:01 PST
Committed r110264: <http://trac.webkit.org/changeset/110264>
Note You need to log in before you can comment on or make changes to this bug.