Bug 80639

Summary: Use an explicit attribute to signal that a context prefers to use a discrete GPU
Product: WebKit Reporter: James Robinson <jamesr>
Component: New BugsAssignee: James Robinson <jamesr>
Status: RESOLVED FIXED    
Severity: Normal CC: abarth, fishd, kbr, piman, senorblanco, webkit.review.bot
Priority: P2    
Version: 528+ (Nightly build)   
Hardware: Unspecified   
OS: Unspecified   
Attachments:
Description Flags
Patch
none
Gpu -> GPU senorblanco: review+

James Robinson
Reported 2012-03-08 14:07:13 PST
Use an explicit attribute to signal that a context prefers to use a discrete GPU
Attachments
Patch (10.78 KB, patch)
2012-03-08 15:03 PST, James Robinson 		no flags
DetailsFormatted DiffDiff
Gpu -> GPU (10.78 KB, patch)
2012-03-08 15:29 PST, James Robinson 		senorblanco: review+
DetailsFormatted DiffDiff
Show Obsolete (1) View All Add attachment proposed patch, testcase, etc.
James Robinson
Comment 1 2012-03-08 15:03:54 PST
Created attachment 130912 [details] Patch
WebKit Review Bot
Comment 2 2012-03-08 15:06:39 PST
Please wait for approval from fishd@chromium.org, abarth@webkit.org or jamesr@chromium.org before submitting because this patch contains changes to the Chromium platform API.
James Robinson
Comment 3 2012-03-08 15:07:15 PST
Chromium side: https://chromiumcodereview.appspot.com/9648014/
Antoine Labour
Comment 4 2012-03-08 15:09:58 PST
LGTM
Stephen White
Comment 5 2012-03-08 15:17:42 PST
Comment on attachment 130912 [details] Patch View in context: https://bugs.webkit.org/attachment.cgi?id=130912&action=review > Source/Platform/chromium/public/WebGraphicsContext3D.h:97 > + , preferDiscreteGpu(false) GPU should be in all-caps, since it's an acronym.
James Robinson
Comment 6 2012-03-08 15:29:58 PST
Created attachment 130919 [details] Gpu -> GPU
Stephen White
Comment 7 2012-03-08 15:46:34 PST
Comment on attachment 130919 [details] Gpu -> GPU Looks good (assuming API approval). r=me
James Robinson
Comment 8 2012-03-08 15:53:14 PST
Committed r110227: <http://trac.webkit.org/changeset/110227>
Note You need to log in before you can comment on or make changes to this bug.