Bug 80639

Summary: Use an explicit attribute to signal that a context prefers to use a discrete GPU
Product: WebKit Reporter: James Robinson <jamesr>
Component: New BugsAssignee: James Robinson <jamesr>
Severity: Normal CC: abarth, fishd, kbr, piman, senorblanco, webkit.review.bot
Priority: P2    
Version: 528+ (Nightly build)   
Hardware: Unspecified   
OS: Unspecified   
Description Flags
Gpu -> GPU senorblanco: review+

Description James Robinson 2012-03-08 14:07:13 PST
Use an explicit attribute to signal that a context prefers to use a discrete GPU
Comment 1 James Robinson 2012-03-08 15:03:54 PST
Created attachment 130912 [details]
Comment 2 WebKit Review Bot 2012-03-08 15:06:39 PST
Please wait for approval from fishd@chromium.org, abarth@webkit.org or jamesr@chromium.org before submitting because this patch contains changes to the Chromium platform API.
Comment 3 James Robinson 2012-03-08 15:07:15 PST
Chromium side: https://chromiumcodereview.appspot.com/9648014/
Comment 4 Antoine Labour 2012-03-08 15:09:58 PST
Comment 5 Stephen White 2012-03-08 15:17:42 PST
Comment on attachment 130912 [details]

View in context: https://bugs.webkit.org/attachment.cgi?id=130912&action=review

> Source/Platform/chromium/public/WebGraphicsContext3D.h:97
> +            , preferDiscreteGpu(false)

GPU should be in all-caps, since it's an acronym.
Comment 6 James Robinson 2012-03-08 15:29:58 PST
Created attachment 130919 [details]
Gpu -> GPU
Comment 7 Stephen White 2012-03-08 15:46:34 PST
Comment on attachment 130919 [details]
Gpu -> GPU

Looks good (assuming API approval).  r=me
Comment 8 James Robinson 2012-03-08 15:53:14 PST
Committed r110227: <http://trac.webkit.org/changeset/110227>