Summary: | Move TransformationMatrix and TransformState to LayoutUnits. | ||||||||||
---|---|---|---|---|---|---|---|---|---|---|---|
Product: | WebKit | Reporter: | Levi Weintraub <leviw> | ||||||||
Component: | Layout and Rendering | Assignee: | Levi Weintraub <leviw> | ||||||||
Status: | RESOLVED FIXED | ||||||||||
Severity: | Normal | CC: | darin, eae, eric, jchaffraix, rakuco, simon.fraser, webkit.review.bot | ||||||||
Priority: | P2 | ||||||||||
Version: | 528+ (Nightly build) | ||||||||||
Hardware: | Unspecified | ||||||||||
OS: | Unspecified | ||||||||||
Bug Depends on: | |||||||||||
Bug Blocks: | 60318 | ||||||||||
Attachments: |
|
Description
Levi Weintraub
2012-03-08 13:16:35 PST
I assume you mean mapRect() and clampedBoundsOfProjectedQuad() in TransformationMatrix (the rest is in doubles). TransformState has no use of IntRect so I'm confused there. You mean HitTestingTransformState? Created attachment 130897 [details]
Patch
Attachment 130897 [details] did not pass style-queue:
Failed to run "['Tools/Scripts/check-webkit-style', '--diff-files', u'Source/WebCore/ChangeLog', u'Source/WebCor..." exit_code: 1
Source/WebCore/platform/graphics/transforms/TransformState.h:83: The parameter name "y" adds no information, so it should be removed. [readability/parameter_name] [5]
Total errors found: 1 in 6 files
If any of these errors are false positives, please file a bug against check-webkit-style.
Comment on attachment 130897 [details]
Patch
Thanks for the review, Simon.
Comment on attachment 130897 [details] Patch Attachment 130897 [details] did not pass qt-ews (qt): Output: http://queues.webkit.org/results/11894159 (In reply to comment #5) > (From update of attachment 130897 [details]) > Attachment 130897 [details] did not pass qt-ews (qt): > Output: http://queues.webkit.org/results/11894159 I've found the build issue with this. I'll upload a fixed patch once this goes through the remaining EWS bots. Comment on attachment 130897 [details] Patch Attachment 130897 [details] did not pass efl-ews (efl): Output: http://queues.webkit.org/results/11906133 Created attachment 130927 [details]
Patch for landing
Attachment 130927 [details] did not pass style-queue:
Failed to run "['Tools/Scripts/check-webkit-style', '--diff-files', u'Source/WebCore/CMakeLists.txt', u'Source/W..." exit_code: 1
Source/WebCore/platform/graphics/transforms/TransformState.h:83: The parameter name "y" adds no information, so it should be removed. [readability/parameter_name] [5]
Total errors found: 1 in 8 files
If any of these errors are false positives, please file a bug against check-webkit-style.
Comment on attachment 130897 [details] Patch View in context: https://bugs.webkit.org/attachment.cgi?id=130897&action=review >> Source/WebCore/platform/graphics/transforms/TransformState.h:83 >> + void move(LayoutUnit x, LayoutUnit y, TransformAccumulation = FlattenTransform); > > The parameter name "y" adds no information, so it should be removed. [readability/parameter_name] [5] Bug in check-webkit-style. I bet it thinks 'y' is a substring of LayoutUnit. Comment on attachment 130927 [details] Patch for landing Rejecting attachment 130927 [details] from commit-queue. Failed to run "['/mnt/git/webkit-commit-queue/Tools/Scripts/webkit-patch', '--status-host=queues.webkit.org', '-..." exit_code: 2 Last 500 characters of output: orm.a(out/Debug/obj.target/Source/WebCore/WebCore.gyp/../../../webcore_platform/Source/WebCore/platform/graphics/transforms/TransformationMatrix.o): in function WebCore::TransformationMatrix::mapRect(WebCore::FractionalLayoutRect const&) const:Source/WebCore/platform/graphics/transforms/TransformationMatrix.cpp:646: error: undefined reference to 'WebCore::enclosingFractionalLayoutRect(WebCore::FloatRect const&)' collect2: ld returned 1 exit status make: *** [out/Debug/webkit_unit_tests] Error 1 Full output: http://queues.webkit.org/results/11892345 Created attachment 131064 [details]
Patch for landing
Attachment 131064 [details] did not pass style-queue:
Failed to run "['Tools/Scripts/check-webkit-style', '--diff-files', u'Source/WebCore/CMakeLists.txt', u'Source/W..." exit_code: 1
Source/WebCore/platform/graphics/transforms/TransformState.h:83: The parameter name "y" adds no information, so it should be removed. [readability/parameter_name] [5]
Total errors found: 1 in 9 files
If any of these errors are false positives, please file a bug against check-webkit-style.
Comment on attachment 131064 [details] Patch for landing Clearing flags on attachment: 131064 Committed r110322: <http://trac.webkit.org/changeset/110322> All reviewed patches have been landed. Closing bug. |