Bug 80626 – [chromium] Only build NEON files if target_arch=="arm"

• Component: New Bugs
• Status: RESOLVED FIXED

[Nico Weber]

[chromium] Only build NEON files fi target_arch=="arm"

[Nico Weber]

Created attachment 130874 [details]
Patch

[Tony Chang]

Comment on attachment 130874 [details]
Patch

View in context: https://bugs.webkit.org/attachment.cgi?id=130874&action=review

> Source/WebCore/ChangeLog:9
> +        Currently, webcore_arm_neon will compile a bunch of files
> +        whose contents are completely ifdef'd away on non-arm, and
> +        then bundle all the generated empty .o files into a useless
> +        libwebcore_arm_neon.a. Don't do this.

This change seems fine since we're not using the lib at all.

> Source/WebCore/ChangeLog:12
> +        Also change the source section from "include everything, then
> +        throw away everything except 6 files" to "list 6 files".

I don't like this because this means we have a file list in two places (confusing for non-chromium people adding new files).  The current design is to have all the files listed WebCore.gypi.  Another way to do this would be to make a new variable in WebCore.gypi that lists the NEON files.

[Nico Weber]

Created attachment 130879 [details]
Patch

[Nico Weber]

> > Source/WebCore/ChangeLog:12
> > +        Also change the source section from "include everything, then
> > +        throw away everything except 6 files" to "list 6 files".
> 
> I don't like this because this means we have a file list in two places (confusing for non-chromium people adding new files).  The current design is to have all the files listed WebCore.gypi.  Another way to do this would be to make a new variable in WebCore.gypi that lists the NEON files.

Reverted that part. Maybe I'll do your suggestin in a follow-up (for platform/ and rendering/, too)

[WebKit Review Bot]

Comment on attachment 130879 [details]
Patch

Clearing flags on attachment: 130879

Committed r110251: <http://trac.webkit.org/changeset/110251>

[WebKit Review Bot]

All reviewed patches have been landed.  Closing bug.