Bug 80625

Summary:

Move DirectoryEntry and DirectoryReader to new Modules/filesystem/ directory

Product:

WebKit

Reporter:

Mark Pilgrim (Google) <pilgrim>

Component:

New Bugs

Assignee:

Mark Pilgrim (Google) <pilgrim>

Status:

RESOLVED FIXED

Severity:

Normal

CC:

abarth, ericu, fishd, haraken, ojan, rakuco, vestbo, webkit.review.bot

Priority:

Version:

528+ (Nightly build)

Hardware:

Unspecified

OS:

Unspecified

Bug Depends on:

80908

Bug Blocks:

Attachments:

Description	Flags
Patch	none
Patch	none
Patch	none
Patch	none

Mark Pilgrim (Google)

Reported 2012-03-08 12:08:48 PST

Move DirectoryEntry and DirectoryReader to new Modules/filesystem/ directory

Attachments
Patch (101.40 KB, patch) 2012-03-08 12:09 PST, Mark Pilgrim (Google)	no flags	Details Formatted Diff Diff
Patch (100.48 KB, patch) 2012-03-12 13:34 PDT, Mark Pilgrim (Google)	no flags	Details Formatted Diff Diff
Patch (102.05 KB, patch) 2012-03-12 17:49 PDT, Mark Pilgrim (Google)	no flags	Details Formatted Diff Diff
Patch (102.92 KB, patch) 2012-03-12 20:04 PDT, Mark Pilgrim (Google)	no flags	Details Formatted Diff Diff
Show Obsolete (3) View All Add attachment proposed patch, testcase, etc.

Mark Pilgrim (Google)

Comment 1 2012-03-08 12:09:56 PST

Created attachment 130872 [details] Patch

Mark Pilgrim (Google)

Comment 2 2012-03-08 12:11:08 PST

This creates the new Modules/filesystem/ subdirectory and moves DirectoryEntry and DirectoryReader files to it, and updates all build systems accordingly.

Adam Barth

Comment 3 2012-03-08 15:01:34 PST

Comment on attachment 130872 [details] Patch This looks fine. It's slightly hard to tell how you're changing the xcodeproj file. It looks like the bots are having trouble applying your patch. Are you synced to top-of-tree? For a patch like this, it's important to run it through the EWS bots so that we can have some confidence that we're not going to break a bunch of builds.

Mark Pilgrim (Google)

Comment 4 2012-03-12 13:34:27 PDT

Created attachment 131395 [details] Patch

Mark Pilgrim (Google)

Comment 5 2012-03-12 13:35:00 PDT

Updated patch from ToT, submitted to EWS.

WebKit Review Bot

Comment 6 2012-03-12 13:38:27 PDT

Attachment 131395 [details] did not pass style-queue: Failed to run "['Tools/Scripts/check-webkit-style', '--diff-files', u'Source/WebCore/CMakeLists.txt', u'Source/W..." exit_code: 1 Source/WebCore/Modules/filesystem/DirectoryEntrySync.h:38: Alphabetical sorting problem. [build/include_order] [4] Source/WebCore/Modules/filesystem/DirectoryEntry.h:38: Alphabetical sorting problem. [build/include_order] [4] Total errors found: 2 in 25 files If any of these errors are false positives, please file a bug against check-webkit-style.

Adam Barth

Comment 7 2012-03-12 15:20:38 PDT

Thanks!

WebKit Review Bot

Comment 8 2012-03-12 16:38:51 PDT

Comment on attachment 131395 [details] Patch Clearing flags on attachment: 131395 Committed r110501: <http://trac.webkit.org/changeset/110501>

WebKit Review Bot

Comment 9 2012-03-12 16:38:57 PDT

All reviewed patches have been landed. Closing bug.

Adam Barth

Comment 10 2012-03-12 17:26:58 PDT

I rolled this patch out because it broke the Apple Windows build.

Mark Pilgrim (Google)

Comment 11 2012-03-12 17:49:42 PDT

Created attachment 131475 [details] Patch

Adam Barth

Comment 12 2012-03-12 17:51:59 PDT

Comment on attachment 131475 [details] Patch View in context: https://bugs.webkit.org/attachment.cgi?id=131475&action=review > Source/WebCore/WebCore.vcproj/WebCore.vcproj:56861 > - RelativePath="..\fileapi\DirectoryEntry.cpp" > + RelativePath="..\Modules\filesystem\DirectoryEntry.cpp" Please move these up higher in the file to their alphabetical place. Note: You'll want to create a filter for filesystem, like the other modules have.

WebKit Review Bot

Comment 13 2012-03-12 17:53:32 PDT

Attachment 131475 [details] did not pass style-queue: Failed to run "['Tools/Scripts/check-webkit-style', '--diff-files', u'Source/WebCore/CMakeLists.txt', u'Source/W..." exit_code: 1 Source/WebCore/Modules/filesystem/DirectoryEntrySync.h:38: Alphabetical sorting problem. [build/include_order] [4] Source/WebCore/Modules/filesystem/DirectoryEntry.h:38: Alphabetical sorting problem. [build/include_order] [4] Total errors found: 2 in 25 files If any of these errors are false positives, please file a bug against check-webkit-style.

Mark Pilgrim (Google)

Comment 14 2012-03-12 20:04:53 PDT

Created attachment 131500 [details] Patch

Mark Pilgrim (Google)

Comment 15 2012-03-12 20:05:21 PDT

Now with filter for filesystem in vcproj.

WebKit Review Bot

Comment 16 2012-03-12 20:08:19 PDT

Attachment 131500 [details] did not pass style-queue: Failed to run "['Tools/Scripts/check-webkit-style', '--diff-files', u'Source/WebCore/CMakeLists.txt', u'Source/W..." exit_code: 1 Source/WebCore/Modules/filesystem/DirectoryEntrySync.h:38: Alphabetical sorting problem. [build/include_order] [4] Source/WebCore/Modules/filesystem/DirectoryEntry.h:38: Alphabetical sorting problem. [build/include_order] [4] Total errors found: 2 in 25 files If any of these errors are false positives, please file a bug against check-webkit-style.

Adam Barth

Comment 17 2012-03-12 22:31:37 PDT

Comment on attachment 131500 [details] Patch View in context: https://bugs.webkit.org/attachment.cgi?id=131500&action=review > Source/WebCore/DerivedSources.make:202 > + $(WebCore)/Modules/filesystem/DirectoryEntry.idl \ > + $(WebCore)/Modules/filesystem/DirectoryEntrySync.idl \ > + $(WebCore)/Modules/filesystem/DirectoryReader.idl \ > + $(WebCore)/Modules/filesystem/DirectoryReaderSync.idl \ Really all of these lists should be alphabetical... Maybe you want to do that in a follow-up patch?

Mark Pilgrim (Google)

Comment 18 2012-03-13 04:29:31 PDT

Comment on attachment 131500 [details] Patch OK, I'll do a followup patch for style cleanup after all the files are moved successfully.

Adam Barth

Comment 19 2012-03-13 10:43:59 PDT

Comment on attachment 131500 [details] Patch The EWS bots predict success!

Mark Pilgrim (Google)

Comment 20 2012-03-13 10:55:40 PDT

So does my astrologist!

WebKit Review Bot

Comment 21 2012-03-13 12:12:21 PDT

Comment on attachment 131500 [details] Patch Clearing flags on attachment: 131500 Committed r110589: <http://trac.webkit.org/changeset/110589>

WebKit Review Bot

Comment 22 2012-03-13 12:12:33 PDT

All reviewed patches have been landed. Closing bug.

Note You need to log in before you can comment on or make changes to this bug.