| Summary: | Move DirectoryEntry and DirectoryReader to new Modules/filesystem/ directory | ||||||||||||
|---|---|---|---|---|---|---|---|---|---|---|---|---|---|
| Product: | WebKit | Reporter: | Mark Pilgrim (Google) <pilgrim> | ||||||||||
| Component: | New Bugs | Assignee: | Mark Pilgrim (Google) <pilgrim> | ||||||||||
| Status: | RESOLVED FIXED | ||||||||||||
| Severity: | Normal | CC: | abarth, ericu, fishd, haraken, ojan, rakuco, vestbo, webkit.review.bot | ||||||||||
| Priority: | P2 | ||||||||||||
| Version: | 528+ (Nightly build) | ||||||||||||
| Hardware: | Unspecified | ||||||||||||
| OS: | Unspecified | ||||||||||||
| Bug Depends on: | 80908 | ||||||||||||
| Bug Blocks: | |||||||||||||
| Attachments: |
|
||||||||||||
|
Description
Mark Pilgrim (Google)
2012-03-08 12:08:48 PST
Created attachment 130872 [details]
Patch
This creates the new Modules/filesystem/ subdirectory and moves DirectoryEntry and DirectoryReader files to it, and updates all build systems accordingly. Comment on attachment 130872 [details]
Patch
This looks fine. It's slightly hard to tell how you're changing the xcodeproj file.
It looks like the bots are having trouble applying your patch. Are you synced to top-of-tree? For a patch like this, it's important to run it through the EWS bots so that we can have some confidence that we're not going to break a bunch of builds.
Created attachment 131395 [details]
Patch
Updated patch from ToT, submitted to EWS. Attachment 131395 [details] did not pass style-queue:
Failed to run "['Tools/Scripts/check-webkit-style', '--diff-files', u'Source/WebCore/CMakeLists.txt', u'Source/W..." exit_code: 1
Source/WebCore/Modules/filesystem/DirectoryEntrySync.h:38: Alphabetical sorting problem. [build/include_order] [4]
Source/WebCore/Modules/filesystem/DirectoryEntry.h:38: Alphabetical sorting problem. [build/include_order] [4]
Total errors found: 2 in 25 files
If any of these errors are false positives, please file a bug against check-webkit-style.
Thanks! Comment on attachment 131395 [details] Patch Clearing flags on attachment: 131395 Committed r110501: <http://trac.webkit.org/changeset/110501> All reviewed patches have been landed. Closing bug. I rolled this patch out because it broke the Apple Windows build. Created attachment 131475 [details]
Patch
Comment on attachment 131475 [details] Patch View in context: https://bugs.webkit.org/attachment.cgi?id=131475&action=review > Source/WebCore/WebCore.vcproj/WebCore.vcproj:56861 > - RelativePath="..\fileapi\DirectoryEntry.cpp" > + RelativePath="..\Modules\filesystem\DirectoryEntry.cpp" Please move these up higher in the file to their alphabetical place. Note: You'll want to create a filter for filesystem, like the other modules have. Attachment 131475 [details] did not pass style-queue:
Failed to run "['Tools/Scripts/check-webkit-style', '--diff-files', u'Source/WebCore/CMakeLists.txt', u'Source/W..." exit_code: 1
Source/WebCore/Modules/filesystem/DirectoryEntrySync.h:38: Alphabetical sorting problem. [build/include_order] [4]
Source/WebCore/Modules/filesystem/DirectoryEntry.h:38: Alphabetical sorting problem. [build/include_order] [4]
Total errors found: 2 in 25 files
If any of these errors are false positives, please file a bug against check-webkit-style.
Created attachment 131500 [details]
Patch
Now with filter for filesystem in vcproj. Attachment 131500 [details] did not pass style-queue:
Failed to run "['Tools/Scripts/check-webkit-style', '--diff-files', u'Source/WebCore/CMakeLists.txt', u'Source/W..." exit_code: 1
Source/WebCore/Modules/filesystem/DirectoryEntrySync.h:38: Alphabetical sorting problem. [build/include_order] [4]
Source/WebCore/Modules/filesystem/DirectoryEntry.h:38: Alphabetical sorting problem. [build/include_order] [4]
Total errors found: 2 in 25 files
If any of these errors are false positives, please file a bug against check-webkit-style.
Comment on attachment 131500 [details] Patch View in context: https://bugs.webkit.org/attachment.cgi?id=131500&action=review > Source/WebCore/DerivedSources.make:202 > + $(WebCore)/Modules/filesystem/DirectoryEntry.idl \ > + $(WebCore)/Modules/filesystem/DirectoryEntrySync.idl \ > + $(WebCore)/Modules/filesystem/DirectoryReader.idl \ > + $(WebCore)/Modules/filesystem/DirectoryReaderSync.idl \ Really all of these lists should be alphabetical... Maybe you want to do that in a follow-up patch? Comment on attachment 131500 [details]
Patch
OK, I'll do a followup patch for style cleanup after all the files are moved successfully.
Comment on attachment 131500 [details]
Patch
The EWS bots predict success!
So does my astrologist! Comment on attachment 131500 [details] Patch Clearing flags on attachment: 131500 Committed r110589: <http://trac.webkit.org/changeset/110589> All reviewed patches have been landed. Closing bug. |