Bug 8062

Summary:

Caret color in new text field should take background color and foreground color into consideration

Product:

WebKit

Reporter:

Adele Peterson <adele>

Component:

Forms

Assignee:

Adele Peterson <adele>

Status:

RESOLVED FIXED

Severity:

Normal

CC:

ian

Priority:

Version:

420+

Hardware:

Mac

OS:

OS X 10.4

Attachments:

Description	Flags
test	none
patch	adele: review-
new patch	hyatt: review+

Adele Peterson

Reported 2006-03-29 15:11:43 PST

Caret color in new text field should match text color

Attachments
test (49 bytes, text/html) 2006-03-30 13:08 PST, Adele Peterson	no flags	Details
patch (707 bytes, patch) 2006-03-30 13:09 PST, Adele Peterson	adele: review-	Details Formatted Diff Diff
new patch (1.62 KB, patch) 2006-11-27 13:23 PST, Adele Peterson	hyatt: review+	Details Formatted Diff Diff
View All Add attachment proposed patch, testcase, etc.

Adele Peterson

Comment 1 2006-03-30 13:08:43 PST

Created attachment 7399 [details] test

Adele Peterson

Comment 2 2006-03-30 13:09:43 PST

Created attachment 7401 [details] patch

Adele Peterson

Comment 3 2006-03-30 15:48:39 PST

Comment on attachment 7401 [details] patch Hyatt and I talked about this. We may want to only do this for text fields... or just use the color of the rootEditableElement....or add a new css property -khtml-caret-color with good default values.

Maciej Stachowiak

Comment 4 2006-04-02 23:25:37 PDT

These are all text field regressions so they should all be P1.

Maciej Stachowiak

Comment 5 2006-04-02 23:29:14 PDT

It's odd that text fields ever did this - rich text NSTextViews don't seem to.

Adele Peterson

Comment 6 2006-04-03 00:18:17 PDT

The old text fields didn't do this. Hyatt and I discussed adding this feature. Bumping back down to P2 since its not a regression.

Adele Peterson

Comment 7 2006-08-25 13:26:23 PDT

Changing title to reflect new goal. We want to choose a white or black caret based on the background color and foreground colors.

Adele Peterson

Comment 8 2006-11-27 13:23:43 PST

Created attachment 11646 [details] new patch Hyatt and I discussed this new approach for this bug. This patch just gets the caret color from the root editable element. This will work well for text controls, and also will work for editable WebViews by just getting the color from the body element.

Dave Hyatt

Comment 9 2006-11-27 13:38:55 PST

Comment on attachment 11646 [details] new patch r=me

Adele Peterson

Comment 10 2006-11-27 13:42:11 PST

Committed revision 17885 worldofwarcraft.com users, rejoice!

Note You need to log in before you can comment on or make changes to this bug.