Bug 80508

Summary: Pinch zoom acts weirdly on nytimes.com while loading
Product: WebKit Reporter: Kenneth Rohde Christiansen <kenneth>
Component: WebKit2Assignee: Kenneth Rohde Christiansen <kenneth>
Status: RESOLVED FIXED    
Severity: Normal CC: hausmann, menard, webkit.review.bot, zalan, zoltan
Priority: P2    
Version: 528+ (Nightly build)   
Hardware: Unspecified   
OS: Unspecified   
Attachments:
Description Flags
Patch
none
Patch none

Description Kenneth Rohde Christiansen 2012-03-07 05:19:32 PST
It blocks and then suddenly jumps between scales.
Comment 1 Kenneth Rohde Christiansen 2012-03-07 05:20:41 PST
Created attachment 130603 [details]
Patch
Comment 2 Andras Becsi 2012-03-07 05:24:08 PST
Comment on attachment 130603 [details]
Patch

View in context: https://bugs.webkit.org/attachment.cgi?id=130603&action=review

LGTM, but I think the last comment line has a typo and an extra "event".

> Source/WebKit2/UIProcess/WebPageProxy.cpp:1012
> +    // we do not send any of the events to the page event if is has listeners.

Shouldn't this line be:
"we do not send any of the events to the page if it has listeners."
Comment 3 Kenneth Rohde Christiansen 2012-03-07 05:26:06 PST
Created attachment 130604 [details]
Patch
Comment 4 Andras Becsi 2012-03-07 05:30:59 PST
Comment on attachment 130604 [details]
Patch

View in context: https://bugs.webkit.org/attachment.cgi?id=130604&action=review

You'll probably hate me for this but there still is a typo in that line :)

> Source/WebKit2/UIProcess/WebPageProxy.cpp:1012
> +    // we do not send any of the events to the page even if is has listeners.

"if is has" should be "if it has"
Comment 5 Kenneth Rohde Christiansen 2012-03-07 05:34:26 PST
Landed in 110048
Comment 6 Alexis Menard (darktears) 2012-03-07 05:34:46 PST
(In reply to comment #4)
> (From update of attachment 130604 [details])
> View in context: https://bugs.webkit.org/attachment.cgi?id=130604&action=review
> 
> You'll probably hate me for this but there still is a typo in that line :)
> 
> > Source/WebKit2/UIProcess/WebPageProxy.cpp:1012
> > +    // we do not send any of the events to the page even if is has listeners.
> 
> "if is has" should be "if it has"

You can turn cq to - but not r to -. He can fix when landing.
Comment 7 Kenneth Rohde Christiansen 2012-03-07 05:35:41 PST
Landed in 110048