Summary: | Pinch zoom acts weirdly on nytimes.com while loading | ||||||||
---|---|---|---|---|---|---|---|---|---|
Product: | WebKit | Reporter: | Kenneth Rohde Christiansen <kenneth> | ||||||
Component: | WebKit2 | Assignee: | Kenneth Rohde Christiansen <kenneth> | ||||||
Status: | RESOLVED FIXED | ||||||||
Severity: | Normal | CC: | hausmann, menard, webkit.review.bot, zalan, zoltan | ||||||
Priority: | P2 | ||||||||
Version: | 528+ (Nightly build) | ||||||||
Hardware: | Unspecified | ||||||||
OS: | Unspecified | ||||||||
Attachments: |
|
Description
Kenneth Rohde Christiansen
2012-03-07 05:19:32 PST
Created attachment 130603 [details]
Patch
Comment on attachment 130603 [details] Patch View in context: https://bugs.webkit.org/attachment.cgi?id=130603&action=review LGTM, but I think the last comment line has a typo and an extra "event". > Source/WebKit2/UIProcess/WebPageProxy.cpp:1012 > + // we do not send any of the events to the page event if is has listeners. Shouldn't this line be: "we do not send any of the events to the page if it has listeners." Created attachment 130604 [details]
Patch
Comment on attachment 130604 [details] Patch View in context: https://bugs.webkit.org/attachment.cgi?id=130604&action=review You'll probably hate me for this but there still is a typo in that line :) > Source/WebKit2/UIProcess/WebPageProxy.cpp:1012 > + // we do not send any of the events to the page even if is has listeners. "if is has" should be "if it has" Landed in 110048 (In reply to comment #4) > (From update of attachment 130604 [details]) > View in context: https://bugs.webkit.org/attachment.cgi?id=130604&action=review > > You'll probably hate me for this but there still is a typo in that line :) > > > Source/WebKit2/UIProcess/WebPageProxy.cpp:1012 > > + // we do not send any of the events to the page even if is has listeners. > > "if is has" should be "if it has" You can turn cq to - but not r to -. He can fix when landing. Landed in 110048 |