Bug 80507

Summary: Web Inspector: [Styles] Click in the first line of rule while editing property starts a new property
Product: WebKit Reporter: Alexander Pavlov (apavlov) <apavlov>
Component: Web Inspector (Deprecated)Assignee: Alexander Pavlov (apavlov) <apavlov>
Status: RESOLVED FIXED    
Severity: Normal CC: apavlov, bweinstein, joepeck, keishi, loislo, pfeldman, pmuellr, rik, timothy, yurys
Priority: P2    
Version: 528+ (Nightly build)   
Hardware: All   
OS: All   
Attachments:
Description Flags
Patch
none
Patch vsevik: review+

Alexander Pavlov (apavlov)
Reported 2012-03-07 04:52:10 PST
Patch to follow.
Attachments
Patch (2.09 KB, patch)
2012-03-07 05:05 PST, Alexander Pavlov (apavlov) 		no flags
DetailsFormatted DiffDiff
Patch (3.27 KB, patch)
2012-03-07 07:13 PST, Alexander Pavlov (apavlov) 		vsevik: review+
DetailsFormatted DiffDiff
Show Obsolete (1) View All Add attachment proposed patch, testcase, etc.
Alexander Pavlov (apavlov)
Comment 1 2012-03-07 05:05:40 PST
Created attachment 130601 [details] Patch
Vsevolod Vlasov
Comment 2 2012-03-07 06:36:37 PST
Comment on attachment 130601 [details] Patch View in context: https://bugs.webkit.org/attachment.cgi?id=130601&action=review > Source/WebCore/inspector/front-end/StylesSidebarPane.js:980 > + selectorContainer.addEventListener("mousedown", this._handleEmptySpaceMouseDown.bind(this), false); We have the same problem for each rule element also. > Source/WebCore/inspector/front-end/StylesSidebarPane.js:1181 > + var willCauseCancelEditing = this._willCauseCancelEditing; Could you please extract this method?
Alexander Pavlov (apavlov)
Comment 3 2012-03-07 07:13:20 PST
Created attachment 130621 [details] Patch
Vsevolod Vlasov
Comment 4 2012-03-07 07:37:37 PST
Comment on attachment 130621 [details] Patch View in context: https://bugs.webkit.org/attachment.cgi?id=130621&action=review > Source/WebCore/inspector/front-end/StylesSidebarPane.js:2031 > + if (this.section._checkWillCancelEditing()) Consider renaming _startEditing to _mouseClicked.
Alexander Pavlov (apavlov)
Comment 5 2012-03-09 01:52:13 PST
Committed r110278: <http://trac.webkit.org/changeset/110278>
Note You need to log in before you can comment on or make changes to this bug.