Bug 80500

Summary: [GTK] remove webkitpy dependency in run-gtk-tests
Product: WebKit Reporter: Philippe Normand <pnormand>
Component: WebKitGTKAssignee: Nobody <webkit-unassigned>
Status: RESOLVED FIXED    
Severity: Normal CC: mrobinson, pnormand
Priority: P2    
Version: 528+ (Nightly build)   
Hardware: Unspecified   
OS: Unspecified   
Bug Depends on: 80495    
Bug Blocks:    
Attachments:
Description Flags
Patch mrobinson: review+

Philippe Normand
Reported 2012-03-07 00:42:08 PST
So it can be shipped in tarballs and used during distcheck.
Attachments
Patch (4.71 KB, patch)
2012-03-07 01:39 PST, Philippe Normand 		mrobinson: review+
DetailsFormatted DiffDiff
View All Add attachment proposed patch, testcase, etc.
Philippe Normand
Comment 1 2012-03-07 01:39:14 PST
Created attachment 130570 [details] Patch
Martin Robinson
Comment 2 2012-03-07 06:42:16 PST
Comment on attachment 130570 [details] Patch View in context: https://bugs.webkit.org/attachment.cgi?id=130570&action=review Great! Thank you! > Tools/Scripts/run-gtk-tests:154 > - out = self._executive.run_command([jhbuild_path ,'gtester', test], env=test_env, > - error_handler=_error_handler) > + process = subprocess.Popen([jhbuild_path ,'gtester', test], env=test_env, stdout=subprocess.PIPE) > + out = process.communicate()[0] > sys.stdout.write(out) If you omit the stdout argument altogether, I believe the default is to route it to stdout anyway. Perhaps you can just omit that and sys.stdout.write(out) sys.stdout.flush() altogether.
Philippe Normand
Comment 3 2012-03-07 06:47:07 PST
Alright I'll try that before landing, thanks :)
Philippe Normand
Comment 4 2012-03-07 09:24:36 PST
Committed r110062: <http://trac.webkit.org/changeset/110062>
Note You need to log in before you can comment on or make changes to this bug.