Summary: | [EFL] Key press event is not processed properly. | ||||||||
---|---|---|---|---|---|---|---|---|---|
Product: | WebKit | Reporter: | ChangSeok Oh <kevin.cs.oh> | ||||||
Component: | WebKit EFL | Assignee: | Nobody <webkit-unassigned> | ||||||
Status: | RESOLVED FIXED | ||||||||
Severity: | Normal | CC: | gyuyoung.kim, lucas.de.marchi, rakuco, webkit.review.bot | ||||||
Priority: | P2 | ||||||||
Version: | 528+ (Nightly build) | ||||||||
Hardware: | Unspecified | ||||||||
OS: | Unspecified | ||||||||
Attachments: |
|
Description
ChangSeok Oh
2012-03-06 22:29:30 PST
Created attachment 130583 [details]
Patch
Comment on attachment 130583 [details] Patch View in context: https://bugs.webkit.org/attachment.cgi?id=130583&action=review It looks that you modify nits of EflKeyboardUtilities | PlatformKeyboardEventEfl as well as add singleCharacterString(). I think this is not match for ChangeLog. I think it is better to split this patch into two patches. > Source/WebCore/ChangeLog:17 > + fast/mutation/end-of-task-delivery.html Trivial nit : Missing "Test:" in front of test case. Created attachment 130615 [details]
Patch
Comment on attachment 130583 [details] Patch View in context: https://bugs.webkit.org/attachment.cgi?id=130583&action=review Thanks for comment. I'll deal with remained changes in bug80511. >> Source/WebCore/ChangeLog:17 >> + fast/mutation/end-of-task-delivery.html > > Trivial nit : Missing "Test:" in front of test case. Done. Comment on attachment 130615 [details]
Patch
OK, looks sensible
Comment on attachment 130615 [details] Patch Clearing flags on attachment: 130615 Committed r110061: <http://trac.webkit.org/changeset/110061> All reviewed patches have been landed. Closing bug. |