Bug 80491

Summary: [EFL] Key press event is not processed properly.
Product: WebKit Reporter: ChangSeok Oh <kevin.cs.oh>
Component: WebKit EFLAssignee: Nobody <webkit-unassigned>
Status: RESOLVED FIXED    
Severity: Normal CC: gyuyoung.kim, lucas.de.marchi, rakuco, webkit.review.bot
Priority: P2    
Version: 528+ (Nightly build)   
Hardware: Unspecified   
OS: Unspecified   
Attachments:
Description Flags
Patch
none
Patch none

Description ChangSeok Oh 2012-03-06 22:29:30 PST
This issue is related with mutation-observer feature.
If I press enter key, then a keyboard event for "Enter key" should be processed and reach to the mutation observer, but it doesn't.
Comment 1 ChangSeok Oh 2012-03-07 02:58:20 PST
Created attachment 130583 [details]
Patch
Comment 2 Gyuyoung Kim 2012-03-07 04:56:46 PST
Comment on attachment 130583 [details]
Patch

View in context: https://bugs.webkit.org/attachment.cgi?id=130583&action=review

It looks that you modify nits of EflKeyboardUtilities | PlatformKeyboardEventEfl as well as add singleCharacterString(). I think this is not match for ChangeLog. I think it is better to split this patch into two patches.

> Source/WebCore/ChangeLog:17
> +        fast/mutation/end-of-task-delivery.html

Trivial nit : Missing "Test:" in front of test case.
Comment 3 ChangSeok Oh 2012-03-07 06:43:24 PST
Created attachment 130615 [details]
Patch
Comment 4 ChangSeok Oh 2012-03-07 06:51:07 PST
Comment on attachment 130583 [details]
Patch

View in context: https://bugs.webkit.org/attachment.cgi?id=130583&action=review

Thanks for comment. I'll deal with remained changes in bug80511.

>> Source/WebCore/ChangeLog:17
>> +        fast/mutation/end-of-task-delivery.html
> 
> Trivial nit : Missing "Test:" in front of test case.

Done.
Comment 5 Gustavo Noronha (kov) 2012-03-07 07:26:58 PST
Comment on attachment 130615 [details]
Patch

OK, looks sensible
Comment 6 WebKit Review Bot 2012-03-07 09:15:22 PST
Comment on attachment 130615 [details]
Patch

Clearing flags on attachment: 130615

Committed r110061: <http://trac.webkit.org/changeset/110061>
Comment 7 WebKit Review Bot 2012-03-07 09:15:27 PST
All reviewed patches have been landed.  Closing bug.