Bug 80425 – [Qt] REGRESSION(r109575) Broke tap-to-zoom gesture

• Component: WebKit2
• Status: RESOLVED FIXED

[Allan Sandfeld Jensen]

Tapping on any page such as google.com would previously cause the view to zoom in. This no longer happens after the patch in r109575.

[Dinu Jacob]

Need to set the startScreenPos for the mock touch point.

[Dinu Jacob]

Created attachment 130504 [details]
Patch

[Simon Hausmann]

Comment on attachment 130504 [details]
Patch

View in context: https://bugs.webkit.org/attachment.cgi?id=130504&action=review

> Tools/MiniBrowser/qt/MiniBrowserApplication.cpp:196
> +        touchPoint.setStartScenePos(m_startScreenPos);

You're right, the double tap recognizer uses the start screen pos, but there's a typo in this line where the start_screen_ pos is set on the start_Scene_ pos property. Please fix before landing :)

[Dinu Jacob]

(In reply to comment #3)
> (From update of attachment 130504 [details])
> View in context: https://bugs.webkit.org/attachment.cgi?id=130504&action=review
> 
> > Tools/MiniBrowser/qt/MiniBrowserApplication.cpp:196
> > +        touchPoint.setStartScenePos(m_startScreenPos);
> 
> You're right, the double tap recognizer uses the start screen pos, but there's a typo in this line where the start_screen_ pos is set on the start_Scene_ pos property. Please fix before landing :)

That was intentional. As canvas translates the touch events we need to set the screen position as the scene position. I can add a comment there.

[Dinu Jacob]

Created attachment 130605 [details]
Updated Patch

[WebKit Review Bot]

Comment on attachment 130605 [details]
Updated Patch

Clearing flags on attachment: 130605

Committed r110058: <http://trac.webkit.org/changeset/110058>

[WebKit Review Bot]

All reviewed patches have been landed.  Closing bug.