Bug 80425

Summary: [Qt] REGRESSION(r109575) Broke tap-to-zoom gesture
Product: WebKit Reporter: Allan Sandfeld Jensen <allan.jensen>
Component: WebKit2Assignee: Nobody <webkit-unassigned>
Status: RESOLVED FIXED    
Severity: Normal CC: abecsi, dinu.jacob, hausmann, webkit.review.bot
Priority: P2    
Version: 528+ (Nightly build)   
Hardware: Unspecified   
OS: Unspecified   
Bug Depends on:    
Bug Blocks: 79119    
Attachments:
Description Flags
Patch
hausmann: review+, hausmann: commit-queue-
Updated Patch none

Description Allan Sandfeld Jensen 2012-03-06 08:19:05 PST
Tapping on any page such as google.com would previously cause the view to zoom in. This no longer happens after the patch in r109575.
Comment 1 Dinu Jacob 2012-03-06 18:04:00 PST
Need to set the startScreenPos for the mock touch point.
Comment 2 Dinu Jacob 2012-03-06 18:05:30 PST
Created attachment 130504 [details]
Patch
Comment 3 Simon Hausmann 2012-03-06 22:51:54 PST
Comment on attachment 130504 [details]
Patch

View in context: https://bugs.webkit.org/attachment.cgi?id=130504&action=review

> Tools/MiniBrowser/qt/MiniBrowserApplication.cpp:196
> +        touchPoint.setStartScenePos(m_startScreenPos);

You're right, the double tap recognizer uses the start screen pos, but there's a typo in this line where the start_screen_ pos is set on the start_Scene_ pos property. Please fix before landing :)
Comment 4 Dinu Jacob 2012-03-07 05:22:16 PST
(In reply to comment #3)
> (From update of attachment 130504 [details])
> View in context: https://bugs.webkit.org/attachment.cgi?id=130504&action=review
> 
> > Tools/MiniBrowser/qt/MiniBrowserApplication.cpp:196
> > +        touchPoint.setStartScenePos(m_startScreenPos);
> 
> You're right, the double tap recognizer uses the start screen pos, but there's a typo in this line where the start_screen_ pos is set on the start_Scene_ pos property. Please fix before landing :)

That was intentional. As canvas translates the touch events we need to set the screen position as the scene position. I can add a comment there.
Comment 5 Dinu Jacob 2012-03-07 05:28:59 PST
Created attachment 130605 [details]
Updated Patch
Comment 6 WebKit Review Bot 2012-03-07 08:56:39 PST
Comment on attachment 130605 [details]
Updated Patch

Clearing flags on attachment: 130605

Committed r110058: <http://trac.webkit.org/changeset/110058>
Comment 7 WebKit Review Bot 2012-03-07 08:56:44 PST
All reviewed patches have been landed.  Closing bug.