Bug 80393

Summary:

Move SQLDatabase code into Modules/webdatabase

Product:

WebKit

Reporter:

Adam Barth <abarth>

Component:

New Bugs

Assignee:

Adam Barth <abarth>

Status:

RESOLVED FIXED

Severity:

Normal

CC:

eric, haraken, levin+threading, ojan, ossy, rakuco, vestbo, webkit.review.bot

Priority:

Version:

528+ (Nightly build)

Hardware:

Unspecified

OS:

Unspecified

Bug Depends on:

Bug Blocks:

79327

Attachments:

Description	Flags
Patch	none
Patch	haraken: review+

Description Adam Barth 2012-03-06 00:31:16 PST

Move SQLDatabase code into Modules/sqldatabase

Comment 1 Adam Barth 2012-03-06 00:34:29 PST

Created attachment 130315 [details]
Patch

Comment 2 WebKit Review Bot 2012-03-06 00:39:45 PST

Attachment 130315 [details] did not pass style-queue:

Source/WebCore/Modules/sqldatabase/DatabaseThread.cpp:55:  Should have only a single space after a punctuation in a comment.  [whitespace/comments] [5]
Source/WebCore/Modules/sqldatabase/SQLResultSetRowList.h:36:  Alphabetical sorting problem.  [build/include_order] [4]
Source/WebCore/Modules/sqldatabase/DatabaseThread.h:59:  The parameter name "taskSynchronizer" adds no information, so it should be removed.  [readability/parameter_name] [5]
Source/WebCore/Modules/sqldatabase/Database.cpp:163:  Should have only a single space after a punctuation in a comment.  [whitespace/comments] [5]
Source/WebCore/Modules/sqldatabase/SQLResultSetRowList.cpp:38:  Tests for true/false, null/non-null, and zero/non-zero should all be done without equality comparisons.  [readability/comparison_to_zero] [5]
Source/WebCore/Modules/sqldatabase/SQLResultSetRowList.cpp:41:  Tests for true/false, null/non-null, and zero/non-zero should all be done without equality comparisons.  [readability/comparison_to_zero] [5]
Source/WebCore/Modules/sqldatabase/DatabaseAuthorizer.h:97:  The parameter name "permissions" adds no information, so it should be removed.  [readability/parameter_name] [5]
Source/WebCore/Modules/sqldatabase/chromium/QuotaTracker.cpp:32:  You should add a blank line after implementation file's own header.  [build/include_order] [4]
Source/WebCore/Modules/sqldatabase/OriginUsageRecord.h:43:  More than one command on the same line  [whitespace/newline] [4]
Source/WebCore/Modules/sqldatabase/OriginQuotaManager.h:45:  More than one command on the same line  [whitespace/newline] [4]
Source/WebCore/Modules/sqldatabase/DatabaseTracker.h:60:  More than one command on the same line  [whitespace/newline] [4]
Source/WebCore/Modules/sqldatabase/DatabaseTracker.h:64:  Should have only a single space after a punctuation in a comment.  [whitespace/comments] [5]
Source/WebCore/Modules/sqldatabase/DatabaseTracker.h:65:  Should have only a single space after a punctuation in a comment.  [whitespace/comments] [5]
Source/WebCore/Modules/sqldatabase/DatabaseTracker.h:77:  The parameter name "origin" adds no information, so it should be removed.  [readability/parameter_name] [5]
Source/WebCore/Modules/sqldatabase/DatabaseTracker.h:114:  The parameter name "origin" adds no information, so it should be removed.  [readability/parameter_name] [5]
Source/WebCore/Modules/sqldatabase/DatabaseTracker.h:116:  The parameter name "origin" adds no information, so it should be removed.  [readability/parameter_name] [5]
Source/WebCore/Modules/sqldatabase/DatabaseTracker.h:117:  The parameter name "origin" adds no information, so it should be removed.  [readability/parameter_name] [5]
Source/WebCore/Modules/sqldatabase/DatabaseTracker.h:118:  The parameter name "origin" adds no information, so it should be removed.  [readability/parameter_name] [5]
Source/WebCore/Modules/sqldatabase/DatabaseTracker.h:159:  The parameter name "origin" adds no information, so it should be removed.  [readability/parameter_name] [5]
Source/WebCore/Modules/sqldatabase/DatabaseTracker.h:160:  The parameter name "origin" adds no information, so it should be removed.  [readability/parameter_name] [5]
Source/WebCore/Modules/sqldatabase/DatabaseTracker.h:161:  The parameter name "origin" adds no information, so it should be removed.  [readability/parameter_name] [5]
Source/WebCore/Modules/sqldatabase/DatabaseTracker.h:162:  The parameter name "origin" adds no information, so it should be removed.  [readability/parameter_name] [5]
Source/WebCore/Modules/sqldatabase/DatabaseTracker.h:163:  The parameter name "origin" adds no information, so it should be removed.  [readability/parameter_name] [5]
Source/WebCore/Modules/sqldatabase/DatabaseTracker.h:164:  The parameter name "origin" adds no information, so it should be removed.  [readability/parameter_name] [5]
Source/WebCore/Modules/sqldatabase/DatabaseTracker.h:165:  The parameter name "origin" adds no information, so it should be removed.  [readability/parameter_name] [5]
Source/WebCore/Modules/sqldatabase/DatabaseTracker.h:166:  The parameter name "origin" adds no information, so it should be removed.  [readability/parameter_name] [5]
Source/WebCore/Modules/sqldatabase/DatabaseTracker.h:167:  The parameter name "origin" adds no information, so it should be removed.  [readability/parameter_name] [5]
Source/WebCore/Modules/sqldatabase/DatabaseTracker.h:168:  The parameter name "origin" adds no information, so it should be removed.  [readability/parameter_name] [5]
Source/WebCore/Modules/sqldatabase/DatabaseTracker.h:169:  The parameter name "origin" adds no information, so it should be removed.  [readability/parameter_name] [5]
Source/WebCore/Modules/sqldatabase/DatabaseTracker.h:170:  The parameter name "origin" adds no information, so it should be removed.  [readability/parameter_name] [5]
Source/WebCore/Modules/sqldatabase/DatabaseTracker.h:184:  The parameter name "database" adds no information, so it should be removed.  [readability/parameter_name] [5]
Source/WebCore/Modules/sqldatabase/AbstractDatabase.h:54:  The parameter name "available" adds no information, so it should be removed.  [readability/parameter_name] [5]
Source/WebCore/Modules/sqldatabase/AbstractDatabase.h:80:  The parameter name "permissions" adds no information, so it should be removed.  [readability/parameter_name] [5]
Source/WebCore/Modules/sqldatabase/DatabaseTask.h:74:  More than one command on the same line  [whitespace/newline] [4]
Source/WebCore/Modules/sqldatabase/DatabaseTracker.cpp:46:  Alphabetical sorting problem.  [build/include_order] [4]
Source/WebCore/Modules/sqldatabase/DatabaseTracker.cpp:473:  Tests for true/false, null/non-null, and zero/non-zero should all be done without equality comparisons.  [readability/comparison_to_zero] [5]
Source/WebCore/Modules/sqldatabase/DatabaseTracker.cpp:673:  One line control clauses should not use braces.  [whitespace/braces] [4]
Source/WebCore/Modules/sqldatabase/DatabaseTracker.cpp:910:  One line control clauses should not use braces.  [whitespace/braces] [4]
Source/WebCore/Modules/sqldatabase/DatabaseTracker.cpp:1001:  Should have only a single space after a punctuation in a comment.  [whitespace/comments] [5]
Source/WebCore/Modules/sqldatabase/chromium/DatabaseTrackerChromium.cpp:39:  Alphabetical sorting problem.  [build/include_order] [4]
Source/WebCore/Modules/sqldatabase/chromium/DatabaseTrackerChromium.cpp:43:  Alphabetical sorting problem.  [build/include_order] [4]
Source/WebCore/Modules/sqldatabase/chromium/DatabaseTrackerChromium.cpp:214:  One space before end of line comments  [whitespace/comments] [5]
Source/WebCore/Modules/sqldatabase/chromium/DatabaseTrackerChromium.cpp:217:  Place brace on its own line for function definitions.  [whitespace/braces] [4]
Source/WebCore/Modules/sqldatabase/SQLStatement.cpp:38:  Alphabetical sorting problem.  [build/include_order] [4]
Source/WebCore/Modules/sqldatabase/SQLStatement.cpp:89:  Should have only a single space after a punctuation in a comment.  [whitespace/comments] [5]
Source/WebCore/Modules/sqldatabase/SQLTransaction.cpp:42:  Alphabetical sorting problem.  [build/include_order] [4]
Source/WebCore/Modules/sqldatabase/SQLTransaction.cpp:44:  Alphabetical sorting problem.  [build/include_order] [4]
Source/WebCore/Modules/sqldatabase/SQLTransaction.cpp:123:  An else if statement should be written as an if statement when the prior "if" concludes with a return, break, continue or goto statement.  [readability/control_flow] [4]
Source/WebCore/Modules/sqldatabase/SQLTransaction.cpp:185:  Boolean expressions that span multiple lines should have their operators on the left side of the line instead of the right side.  [whitespace/operators] [4]
Source/WebCore/Modules/sqldatabase/SQLTransaction.cpp:186:  Boolean expressions that span multiple lines should have their operators on the left side of the line instead of the right side.  [whitespace/operators] [4]
Source/WebCore/Modules/sqldatabase/SQLTransaction.cpp:187:  Boolean expressions that span multiple lines should have their operators on the left side of the line instead of the right side.  [whitespace/operators] [4]
Source/WebCore/ModuFailed to run "['Tools/Scripts/check-webkit-style', '--diff-files', u'Source/WebCore/CMakeLists.txt', u'Source/W..." exit_code: 1
les/sqldatabase/SQLTransaction.cpp:188:  Boolean expressions that span multiple lines should have their operators on the left side of the line instead of the right side.  [whitespace/operators] [4]
Source/WebCore/Modules/sqldatabase/SQLTransaction.cpp:189:  Boolean expressions that span multiple lines should have their operators on the left side of the line instead of the right side.  [whitespace/operators] [4]
Source/WebCore/Modules/sqldatabase/SQLTransaction.cpp:205:  Boolean expressions that span multiple lines should have their operators on the left side of the line instead of the right side.  [whitespace/operators] [4]
Source/WebCore/Modules/sqldatabase/SQLTransaction.cpp:206:  Boolean expressions that span multiple lines should have their operators on the left side of the line instead of the right side.  [whitespace/operators] [4]
Source/WebCore/Modules/sqldatabase/SQLTransaction.cpp:207:  Boolean expressions that span multiple lines should have their operators on the left side of the line instead of the right side.  [whitespace/operators] [4]
Source/WebCore/Modules/sqldatabase/SQLTransaction.cpp:208:  Boolean expressions that span multiple lines should have their operators on the left side of the line instead of the right side.  [whitespace/operators] [4]
Source/WebCore/Modules/sqldatabase/SQLTransaction.cpp:363:  Should have only a single space after a punctuation in a comment.  [whitespace/comments] [5]
Source/WebCore/Modules/sqldatabase/SQLTransaction.cpp:375:  Should have only a single space after a punctuation in a comment.  [whitespace/comments] [5]
Source/WebCore/Modules/sqldatabase/SQLTransaction.cpp:388:  One line control clauses should not use braces.  [whitespace/braces] [4]
Source/WebCore/Modules/sqldatabase/SQLTransaction.cpp:584:  One line control clauses should not use braces.  [whitespace/braces] [4]
Source/WebCore/Modules/sqldatabase/SQLTransaction.cpp:622:  Should have only a single space after a punctuation in a comment.  [whitespace/comments] [5]
Source/WebCore/Modules/sqldatabase/SQLTransactionClient.h:46:  More than one command on the same line  [whitespace/newline] [4]
Source/WebCore/Modules/sqldatabase/DatabaseAuthorizer.cpp:416:  Should have a space between // and comment  [whitespace/comments] [4]
Source/WebCore/Modules/sqldatabase/SQLTransactionCoordinator.h:44:  Code inside a namespace should not be indented.  [whitespace/indent] [4]
Source/WebCore/Modules/sqldatabase/SQLTransactionCoordinator.h:47:  More than one command on the same line  [whitespace/newline] [4]
Source/WebCore/Modules/sqldatabase/SQLTransactionCoordinator.h:64:  The parameter name "info" adds no information, so it should be removed.  [readability/parameter_name] [5]
Total errors found: 67 in 89 files


If any of these errors are false positives, please file a bug against check-webkit-style.

Comment 3 Adam Barth 2012-03-06 00:50:20 PST

Created attachment 130324 [details]
Patch

Comment 4 Kentaro Hara 2012-03-06 00:53:40 PST

Comment on attachment 130324 [details]
Patch

Thanks for the modularization! Please rename DOMWindowSQLDatabase.* and WorkerContextSQLDatabase.* in a follow-up patch.

Comment 5 WebKit Review Bot 2012-03-06 00:55:39 PST

Attachment 130324 [details] did not pass style-queue:

Source/WebCore/Modules/webdatabase/DatabaseTracker.cpp:46:  Alphabetical sorting problem.  [build/include_order] [4]
Source/WebCore/Modules/webdatabase/DatabaseTracker.cpp:473:  Tests for true/false, null/non-null, and zero/non-zero should all be done without equality comparisons.  [readability/comparison_to_zero] [5]
Source/WebCore/Modules/webdatabase/DatabaseTracker.cpp:673:  One line control clauses should not use braces.  [whitespace/braces] [4]
Source/WebCore/Modules/webdatabase/DatabaseTracker.cpp:910:  One line control clauses should not use braces.  [whitespace/braces] [4]
Source/WebCore/Modules/webdatabase/DatabaseTracker.cpp:1001:  Should have only a single space after a punctuation in a comment.  [whitespace/comments] [5]
Source/WebCore/Modules/webdatabase/SQLResultSetRowList.cpp:38:  Tests for true/false, null/non-null, and zero/non-zero should all be done without equality comparisons.  [readability/comparison_to_zero] [5]
Source/WebCore/Modules/webdatabase/SQLResultSetRowList.cpp:41:  Tests for true/false, null/non-null, and zero/non-zero should all be done without equality comparisons.  [readability/comparison_to_zero] [5]
Source/WebCore/Modules/webdatabase/SQLResultSetRowList.h:36:  Alphabetical sorting problem.  [build/include_order] [4]
Source/WebCore/Modules/webdatabase/OriginQuotaManager.h:45:  More than one command on the same line  [whitespace/newline] [4]
Source/WebCore/Modules/webdatabase/OriginUsageRecord.h:43:  More than one command on the same line  [whitespace/newline] [4]
Source/WebCore/Modules/webdatabase/AbstractDatabase.h:54:  The parameter name "available" adds no information, so it should be removed.  [readability/parameter_name] [5]
Source/WebCore/Modules/webdatabase/AbstractDatabase.h:80:  The parameter name "permissions" adds no information, so it should be removed.  [readability/parameter_name] [5]
Source/WebCore/Modules/webdatabase/chromium/DatabaseTrackerChromium.cpp:39:  Alphabetical sorting problem.  [build/include_order] [4]
Source/WebCore/Modules/webdatabase/chromium/DatabaseTrackerChromium.cpp:43:  Alphabetical sorting problem.  [build/include_order] [4]
Source/WebCore/Modules/webdatabase/chromium/DatabaseTrackerChromium.cpp:214:  One space before end of line comments  [whitespace/comments] [5]
Source/WebCore/Modules/webdatabase/chromium/DatabaseTrackerChromium.cpp:217:  Place brace on its own line for function definitions.  [whitespace/braces] [4]
Source/WebCore/Modules/webdatabase/SQLStatement.cpp:38:  Alphabetical sorting problem.  [build/include_order] [4]
Source/WebCore/Modules/webdatabase/SQLStatement.cpp:89:  Should have only a single space after a punctuation in a comment.  [whitespace/comments] [5]
Source/WebCore/Modules/webdatabase/chromium/QuotaTracker.cpp:32:  You should add a blank line after implementation file's own header.  [build/include_order] [4]
Source/WebCore/Modules/webdatabase/SQLTransactionCoordinator.h:44:  Code inside a namespace should not be indented.  [whitespace/indent] [4]
Source/WebCore/Modules/webdatabase/SQLTransactionCoordinator.h:47:  More than one command on the same line  [whitespace/newline] [4]
Source/WebCore/Modules/webdatabase/SQLTransactionCoordinator.h:64:  The parameter name "info" adds no information, so it should be removed.  [readability/parameter_name] [5]
Source/WebCore/Modules/webdatabase/SQLTransaction.cpp:42:  Alphabetical sorting problem.  [build/include_order] [4]
Source/WebCore/Modules/webdatabase/SQLTransaction.cpp:44:  Alphabetical sorting problem.  [build/include_order] [4]
Source/WebCore/Modules/webdatabase/SQLTransaction.cpp:123:  An else if statement should be written as an if statement when the prior "if" concludes with a return, break, continue or goto statement.  [readability/control_flow] [4]
Source/WebCore/Modules/webdatabase/SQLTransaction.cpp:185:  Boolean expressions that span multiple lines should have their operators on the left side of the line instead of the right side.  [whitespace/operators] [4]
Source/WebCore/Modules/webdatabase/SQLTransaction.cpp:186:  Boolean expressions that span multiple lines should have their operators on the left side of the line instead of the right side.  [whitespace/operators] [4]
Source/WebCore/Modules/webdatabase/SQLTransaction.cpp:187:  Boolean expressions that span multiple lines should have their operators on the left side of the line instead of the right side.  [whitespace/operators] [4]
Source/WebCore/Modules/webdatabase/SQLTransaction.cpp:188:  Boolean expressions that span multiple lines should have their operators on the left side of the line instead of the right side.  [whitespace/operators] [4]
Source/WebCore/Modules/webdatabase/SQLTransaction.cpp:189:  Boolean expressions that span multiple lines should have their operators on the left side of the line instead of the right side.  [whitespace/operators] [4]
Source/WebCore/Modules/webdatabase/SQLTransaction.cpp:205:  Boolean expressions that span multiple lines should have their operators on the left side of the line instead of the right side.  [whitespace/operators] [4]
Source/WebCore/Modules/webdatabase/SQLTransaction.cpp:206:  Boolean expressions that span multiple lines should have their operators on the left side of the line instead of the right side.  [whitespace/operators] [4]
Source/WebCore/Modules/webdatabase/SQLTransaction.cpp:207:  Boolean expressions that span multiple lines should have their operators on the left side of the line instead of the right side.  [whitespace/operators] [4]
Source/WebCore/Modules/webdatabase/SQLTransaction.cpp:208:  Boolean expressions that span multiple lines should have their operators on the left side of the line instead of the right side.  [whitespace/operators] [4]
Source/WebCore/Modules/webdatabase/SQLTransaction.cpp:363:  Should have only a single space after a punctuation in a comment.  [whitespace/comments] [5]
Source/WebCore/Modules/webdatabase/SQLTransaction.cpp:375:  Should have only a single space after a punctuation in a comment.  [whitespace/comments] [5]
Source/WebCore/Modules/webdatabase/SQLTransaction.cpp:388:  One line control clauses should not use braces.  [whitespace/braces] [4]
Source/WebCore/Modules/webdatabase/SQLTransaction.cpp:584:  One line control clauses should not use braces.  [whitespace/braces] [4]
Source/WebCore/Modules/webdatabase/SQLTransaction.cpp:622:  Should have only a single space after a punctuation in a comment.  [whitespace/comments] [5]
Source/WebCore/Modules/webdatabase/DatabaseAuthorizer.cpp:416:  Should have a space between // and comment  [whitespace/comments] [4]
Source/WebCore/Modules/webdatabase/DatabaseTask.h:74:  More than one command on the same line  [whitespace/newline] [4]
Source/WebCore/Modules/webdatabase/DatabaseAuthorizer.h:97:  The parameter name "permissions" adds no information, so it should be removed.  [readability/parameter_name] [5]
Source/WebCore/Modules/webdatabase/SQLTransactionClient.h:46:  More than one command on the same line  [whitespace/newline] [4]
Source/WebCore/Modules/webdatabase/DatabaseThread.h:59:  The parameter name "taskSynchronizer" adds no information, so it should be removed.  [readability/parameter_name] [5]
Source/WebCore/Modules/webdatabase/Database.cpp:163:  Should have only a single space after a punctuation in a comment.  [whitespace/comments] [5]
Source/WebCore/Modules/webdatabase/DatabaseThread.cpp:55:  Should have only a single space after a punctuation in a comment.  [whitespace/comments] [5]
Source/WebCore/Modules/webdatabase/DatabaseTracker.h:60:  More than one command on the same line  [whitespace/newline] [4]
Source/WebCore/Modules/webdatabase/DatabaseTracker.h:64:  Should have only a single space after a punctuation in a comment.  [whitespace/comments] [5]
Source/WebCore/Modules/webdatabase/DatabaseTracker.h:65:  Should have only a single space after a punctuation in a comment.  [whitespace/comments] [5]
Source/WebCore/Modules/webdatabase/DatabaseTracker.h:77:  The parameter name "origin" adds no information, so it should be removed.  [readability/parameter_name] [5]
Source/WebCore/Modules/webdatabase/DatabaseTracker.h:114:  The parameter name "origin" adds no information, so it should beFailed to run "['Tools/Scripts/check-webkit-style', '--diff-files', u'Source/WebCore/CMakeLists.txt', u'Source/W..." exit_code: 1
 removed.  [readability/parameter_name] [5]
Source/WebCore/Modules/webdatabase/DatabaseTracker.h:116:  The parameter name "origin" adds no information, so it should be removed.  [readability/parameter_name] [5]
Source/WebCore/Modules/webdatabase/DatabaseTracker.h:117:  The parameter name "origin" adds no information, so it should be removed.  [readability/parameter_name] [5]
Source/WebCore/Modules/webdatabase/DatabaseTracker.h:118:  The parameter name "origin" adds no information, so it should be removed.  [readability/parameter_name] [5]
Source/WebCore/Modules/webdatabase/DatabaseTracker.h:159:  The parameter name "origin" adds no information, so it should be removed.  [readability/parameter_name] [5]
Source/WebCore/Modules/webdatabase/DatabaseTracker.h:160:  The parameter name "origin" adds no information, so it should be removed.  [readability/parameter_name] [5]
Source/WebCore/Modules/webdatabase/DatabaseTracker.h:161:  The parameter name "origin" adds no information, so it should be removed.  [readability/parameter_name] [5]
Source/WebCore/Modules/webdatabase/DatabaseTracker.h:162:  The parameter name "origin" adds no information, so it should be removed.  [readability/parameter_name] [5]
Source/WebCore/Modules/webdatabase/DatabaseTracker.h:163:  The parameter name "origin" adds no information, so it should be removed.  [readability/parameter_name] [5]
Source/WebCore/Modules/webdatabase/DatabaseTracker.h:164:  The parameter name "origin" adds no information, so it should be removed.  [readability/parameter_name] [5]
Source/WebCore/Modules/webdatabase/DatabaseTracker.h:165:  The parameter name "origin" adds no information, so it should be removed.  [readability/parameter_name] [5]
Source/WebCore/Modules/webdatabase/DatabaseTracker.h:166:  The parameter name "origin" adds no information, so it should be removed.  [readability/parameter_name] [5]
Source/WebCore/Modules/webdatabase/DatabaseTracker.h:167:  The parameter name "origin" adds no information, so it should be removed.  [readability/parameter_name] [5]
Source/WebCore/Modules/webdatabase/DatabaseTracker.h:168:  The parameter name "origin" adds no information, so it should be removed.  [readability/parameter_name] [5]
Source/WebCore/Modules/webdatabase/DatabaseTracker.h:169:  The parameter name "origin" adds no information, so it should be removed.  [readability/parameter_name] [5]
Source/WebCore/Modules/webdatabase/DatabaseTracker.h:170:  The parameter name "origin" adds no information, so it should be removed.  [readability/parameter_name] [5]
Source/WebCore/Modules/webdatabase/DatabaseTracker.h:184:  The parameter name "database" adds no information, so it should be removed.  [readability/parameter_name] [5]
Total errors found: 67 in 89 files


If any of these errors are false positives, please file a bug against check-webkit-style.

Comment 6 Adam Barth 2012-03-06 01:22:35 PST

Committed r109877: <http://trac.webkit.org/changeset/109877>

Comment 7 Csaba Osztrogonác 2012-03-06 01:37:28 PST

Reopen, because it broke --minimal build:
/usr/bin/gold: /ramdisk/qt-linux-release-minimal/build/WebKitBuild/Release/Source/WebCore/release/libWebCore.a(SQLiteDatabase.o): in function WebCore::SQLiteDatabase::authorizerFunction(void*, int, char const*, char const*, char const*, char const*):SQLiteDatabase.cpp(.text._ZN7WebCore14SQLiteDatabase18authorizerFunctionEPviPKcS3_S3_S3_+0x72): error: undefined reference to 'WebCore::DatabaseAuthorizer::allowFunction(WTF::String const&)'
/usr/bin/gold: /ramdisk/qt-linux-release-minimal/build/WebKitBuild/Release/Source/WebCore/release/libWebCore.a(SQLiteDatabase.o): in function WebCore::SQLiteDatabase::authorizerFunction(void*, int, char const*, char const*, char const*, char const*):SQLiteDatabase.cpp(.text._ZN7WebCore14SQLiteDatabase18authorizerFunctionEPviPKcS3_S3_S3_+0xd0): error: undefined reference to 'WebCore::DatabaseAuthorizer::dropVTable(WTF::String const&, WTF::String const&)'
/usr/bin/gold: /ramdisk/qt-linux-release-minimal/build/WebKitBuild/Release/Source/WebCore/release/libWebCore.a(SQLiteDatabase.o): in function WebCore::SQLiteDatabase::authorizerFunction(void*, int, char const*, char const*, char const*, char const*):SQLiteDatabase.cpp(.text._ZN7WebCore14SQLiteDatabase18authorizerFunctionEPviPKcS3_S3_S3_+0x140): error: undefined reference to 'WebCore::DatabaseAuthorizer::createVTable(WTF::String const&, WTF::String const&)'
/usr/bin/gold: /ramdisk/qt-linux-release-minimal/build/WebKitBuild/Release/Source/WebCore/release/libWebCore.a(SQLiteDatabase.o): in function WebCore::SQLiteDatabase::authorizerFunction(void*, int, char const*, char const*, char const*, char const*):SQLiteDatabase.cpp(.text._ZN7WebCore14SQLiteDatabase18authorizerFunctionEPviPKcS3_S3_S3_+0x182): error: undefined reference to 'WebCore::DatabaseAuthorizer::allowAnalyze(WTF::String const&)'
/usr/bin/gold: /ramdisk/qt-linux-release-minimal/build/WebKitBuild/Release/Source/WebCore/release/libWebCore.a(SQLiteDatabase.o): in function WebCore::SQLiteDatabase::authorizerFunction(void*, int, char const*, char const*, char const*, char const*):SQLiteDatabase.cpp(.text._ZN7WebCore14SQLiteDatabase18authorizerFunctionEPviPKcS3_S3_S3_+0x1ba): error: undefined reference to 'WebCore::DatabaseAuthorizer::allowReindex(WTF::String const&)'
/usr/bin/gold: /ramdisk/qt-linux-release-minimal/build/WebKitBuild/Release/Source/WebCore/release/libWebCore.a(SQLiteDatabase.o): in function WebCore::SQLiteDatabase::authorizerFunction(void*, int, char const*, char const*, char const*, char const*):SQLiteDatabase.cpp(.text._ZN7WebCore14SQLiteDatabase18authorizerFunctionEPviPKcS3_S3_S3_+0x21a): error: undefined reference to 'WebCore::DatabaseAuthorizer::dropTrigger(WTF::String const&, WTF::String const&)'
/usr/bin/gold: /ramdisk/qt-linux-release-minimal/build/WebKitBuild/Release/Source/WebCore/release/libWebCore.a(SQLiteDatabase.o): in function WebCore::SQLiteDatabase::authorizerFunction(void*, int, char const*, char const*, char const*, char const*):SQLiteDatabase.cpp(.text._ZN7WebCore14SQLiteDatabase18authorizerFunctionEPviPKcS3_S3_S3_+0x25a): error: undefined reference to 'WebCore::DatabaseAuthorizer::allowAttach(WTF::String const&)'
/usr/bin/gold: /ramdisk/qt-linux-release-minimal/build/WebKitBuild/Release/Source/WebCore/release/libWebCore.a(SQLiteDatabase.o): in function WebCore::SQLiteDatabase::authorizerFunction(void*, int, char const*, char const*, char const*, char const*):SQLiteDatabase.cpp(.text._ZN7WebCore14SQLiteDatabase18authorizerFunctionEPviPKcS3_S3_S3_+0x2c0): error: undefined reference to 'WebCore::DatabaseAuthorizer::allowUpdate(WTF::String const&, WTF::String const&)'
/usr/bin/gold: /ramdisk/qt-linux-release-minimal/build/WebKitBuild/Release/Source/WebCore/release/libWebCore.a(SQLiteDatabase.o): in function WebCore::SQLiteDatabase::authorizerFunction(void*, int, char const*, char const*, char const*, char const*):SQLiteDatabase.cpp(.text._ZN7WebCore14SQLiteDatabase18authorizerFunctionEPviPKcS3_S3_S3_+0x2ff): error: undefined reference to 'WebCore::DatabaseAuthorizer::createView(WTF::String const&)'
/usr/bin/gold: /ramdisk/qt-linux-release-minimal/build/WebKitBuild/Release/Source/WebCore/release/libWebCore.a(SQLiteDatabase.o): in function WebCore::SQLiteDatabase::authorizerFunction(void*, int, char const*, char const*, char const*, char const*):SQLiteDatabase.cpp(.text._ZN7WebCore14SQLiteDatabase18authorizerFunctionEPviPKcS3_S3_S3_+0x35a): error: undefined reference to 'WebCore::DatabaseAuthorizer::createTrigger(WTF::String const&, WTF::String const&)'
/usr/bin/gold: /ramdisk/qt-linux-release-minimal/build/WebKitBuild/Release/Source/WebCore/release/libWebCore.a(SQLiteDatabase.o): in function WebCore::SQLiteDatabase::authorizerFunction(void*, int, char const*, char const*, char const*, char const*):SQLiteDatabase.cpp(.text._ZN7WebCore14SQLiteDatabase18authorizerFunctionEPviPKcS3_S3_S3_+0x3c8): error: undefined reference to 'WebCore::DatabaseAuthorizer::allowAlterTable(WTF::String const&, WTF::String const&)'
/usr/bin/gold: /ramdisk/qt-linux-release-minimal/build/WebKitBuild/Release/Source/WebCore/release/libWebCore.a(SQLiteDatabase.o): in function WebCore::SQLiteDatabase::authorizerFunction(void*, int, char const*, char const*, char const*, char const*):SQLiteDatabase.cpp(.text._ZN7WebCore14SQLiteDatabase18authorizerFunctionEPviPKcS3_S3_S3_+0x40a): error: undefined reference to 'WebCore::DatabaseAuthorizer::allowDetach(WTF::String const&)'
/usr/bin/gold: /ramdisk/qt-linux-release-minimal/build/WebKitBuild/Release/Source/WebCore/release/libWebCore.a(SQLiteDatabase.o): in function WebCore::SQLiteDatabase::authorizerFunction(void*, int, char const*, char const*, char const*, char const*):SQLiteDatabase.cpp(.text._ZN7WebCore14SQLiteDatabase18authorizerFunctionEPviPKcS3_S3_S3_+0x46a): error: undefined reference to 'WebCore::DatabaseAuthorizer::dropTempIndex(WTF::String const&, WTF::String const&)'
/usr/bin/gold: /ramdisk/qt-linux-release-minimal/build/WebKitBuild/Release/Source/WebCore/release/libWebCore.a(SQLiteDatabase.o): in function WebCore::SQLiteDatabase::authorizerFunction(void*, int, char const*, char const*, char const*, char const*):SQLiteDatabase.cpp(.text._ZN7WebCore14SQLiteDatabase18authorizerFunctionEPviPKcS3_S3_S3_+0x4d8): error: undefined reference to 'WebCore::DatabaseAuthorizer::allowRead(WTF::String const&, WTF::String const&)'
/usr/bin/gold: /ramdisk/qt-linux-release-minimal/build/WebKitBuild/Release/Source/WebCore/release/libWebCore.a(SQLiteDatabase.o): in function WebCore::SQLiteDatabase::authorizerFunction(void*, int, char const*, char const*, char const*, char const*):SQLiteDatabase.cpp(.text._ZN7WebCore14SQLiteDatabase18authorizerFunctionEPviPKcS3_S3_S3_+0x548): error: undefined reference to 'WebCore::DatabaseAuthorizer::allowPragma(WTF::String const&, WTF::String const&)'
/usr/bin/gold: /ramdisk/qt-linux-release-minimal/build/WebKitBuild/Release/Source/WebCore/release/libWebCore.a(SQLiteDatabase.o): in function WebCore::SQLiteDatabase::authorizerFunction(void*, int, char const*, char const*, char const*, char const*):SQLiteDatabase.cpp(.text._ZN7WebCore14SQLiteDatabase18authorizerFunctionEPviPKcS3_S3_S3_+0x587): error: undefined reference to 'WebCore::DatabaseAuthorizer::createTempTable(WTF::String const&)'
/usr/bin/gold: /ramdisk/qt-linux-release-minimal/build/WebKitBuild/Release/Source/WebCore/release/libWebCore.a(SQLiteDatabase.o): in function WebCore::SQLiteDatabase::authorizerFunction(void*, int, char const*, char const*, char const*, char const*):SQLiteDatabase.cpp(.text._ZN7WebCore14SQLiteDatabase18authorizerFunctionEPviPKcS3_S3_S3_+0x5e2): error: undefined reference to 'WebCore::DatabaseAuthorizer::createTempIndex(WTF::String const&, WTF::String const&)'
/usr/bin/gold: /ramdisk/qt-linux-release-minimal/build/WebKitBuild/Release/Source/WebCore/release/libWebCore.a(SQLiteDatabase.o): in function WebCore::SQLiteDatabase::authorizerFunction(void*, int, char const*, char const*, char const*, char const*):SQLiteDatabase.cpp(.text._ZN7WebCore14SQLiteDatabase18authorizerFunctionEPviPKcS3_S3_S3_+0x60c): error: undefined reference to 'WebCore::DatabaseAuthorizer::allowTransaction()'
/usr/bin/gold: /ramdisk/qt-linux-release-minimal/build/WebKitBuild/Release/Source/WebCore/release/libWebCore.a(SQLiteDatabase.o): in function WebCore::SQLiteDatabase::authorizerFunction(void*, int, char const*, char const*, char const*, char const*):SQLiteDatabase.cpp(.text._ZN7WebCore14SQLiteDatabase18authorizerFunctionEPviPKcS3_S3_S3_+0x66a): error: undefined reference to 'WebCore::DatabaseAuthorizer::dropTempTrigger(WTF::String const&, WTF::String const&)'
/usr/bin/gold: /ramdisk/qt-linux-release-minimal/build/WebKitBuild/Release/Source/WebCore/release/libWebCore.a(SQLiteDatabase.o): in function WebCore::SQLiteDatabase::authorizerFunction(void*, int, char const*, char const*, char const*, char const*):SQLiteDatabase.cpp(.text._ZN7WebCore14SQLiteDatabase18authorizerFunctionEPviPKcS3_S3_S3_+0x6a7): error: undefined reference to 'WebCore::DatabaseAuthorizer::dropTempTable(WTF::String const&)'
/usr/bin/gold: /ramdisk/qt-linux-release-minimal/build/WebKitBuild/Release/Source/WebCore/release/libWebCore.a(SQLiteDatabase.o): in function WebCore::SQLiteDatabase::authorizerFunction(void*, int, char const*, char const*, char const*, char const*):SQLiteDatabase.cpp(.text._ZN7WebCore14SQLiteDatabase18authorizerFunctionEPviPKcS3_S3_S3_+0x6d7): error: undefined reference to 'WebCore::DatabaseAuthorizer::allowInsert(WTF::String const&)'
/usr/bin/gold: /ramdisk/qt-linux-release-minimal/build/WebKitBuild/Release/Source/WebCore/release/libWebCore.a(SQLiteDatabase.o): in function WebCore::SQLiteDatabase::authorizerFunction(void*, int, char const*, char const*, char const*, char const*):SQLiteDatabase.cpp(.text._ZN7WebCore14SQLiteDatabase18authorizerFunctionEPviPKcS3_S3_S3_+0x707): error: undefined reference to 'WebCore::DatabaseAuthorizer::createTempView(WTF::String const&)'
/usr/bin/gold: /ramdisk/qt-linux-release-minimal/build/WebKitBuild/Release/Source/WebCore/release/libWebCore.a(SQLiteDatabase.o): in function WebCore::SQLiteDatabase::authorizerFunction(void*, int, char const*, char const*, char const*, char const*):SQLiteDatabase.cpp(.text._ZN7WebCore14SQLiteDatabase18authorizerFunctionEPviPKcS3_S3_S3_+0x737): error: undefined reference to 'WebCore::DatabaseAuthorizer::dropView(WTF::String const&)'
/usr/bin/gold: /ramdisk/qt-linux-release-minimal/build/WebKitBuild/Release/Source/WebCore/release/libWebCore.a(SQLiteDatabase.o): in function WebCore::SQLiteDatabase::authorizerFunction(void*, int, char const*, char const*, char const*, char const*):SQLiteDatabase.cpp(.text._ZN7WebCore14SQLiteDatabase18authorizerFunctionEPviPKcS3_S3_S3_+0x792): error: undefined reference to 'WebCore::DatabaseAuthorizer::dropIndex(WTF::String const&, WTF::String const&)'
/usr/bin/gold: /ramdisk/qt-linux-release-minimal/build/WebKitBuild/Release/Source/WebCore/release/libWebCore.a(SQLiteDatabase.o): in function WebCore::SQLiteDatabase::authorizerFunction(void*, int, char const*, char const*, char const*, char const*):SQLiteDatabase.cpp(.text._ZN7WebCore14SQLiteDatabase18authorizerFunctionEPviPKcS3_S3_S3_+0x7cf): error: undefined reference to 'WebCore::DatabaseAuthorizer::createTable(WTF::String const&)'
/usr/bin/gold: /ramdisk/qt-linux-release-minimal/build/WebKitBuild/Release/Source/WebCore/release/libWebCore.a(SQLiteDatabase.o): in function WebCore::SQLiteDatabase::authorizerFunction(void*, int, char const*, char const*, char const*, char const*):SQLiteDatabase.cpp(.text._ZN7WebCore14SQLiteDatabase18authorizerFunctionEPviPKcS3_S3_S3_+0x82a): error: undefined reference to 'WebCore::DatabaseAuthorizer::createIndex(WTF::String const&, WTF::String const&)'
/usr/bin/gold: /ramdisk/qt-linux-release-minimal/build/WebKitBuild/Release/Source/WebCore/release/libWebCore.a(SQLiteDatabase.o): in function WebCore::SQLiteDatabase::authorizerFunction(void*, int, char const*, char const*, char const*, char const*):SQLiteDatabase.cpp(.text._ZN7WebCore14SQLiteDatabase18authorizerFunctionEPviPKcS3_S3_S3_+0x867): error: undefined reference to 'WebCore::DatabaseAuthorizer::dropTempView(WTF::String const&)'
/usr/bin/gold: /ramdisk/qt-linux-release-minimal/build/WebKitBuild/Release/Source/WebCore/release/libWebCore.a(SQLiteDatabase.o): in function WebCore::SQLiteDatabase::authorizerFunction(void*, int, char const*, char const*, char const*, char const*):SQLiteDatabase.cpp(.text._ZN7WebCore14SQLiteDatabase18authorizerFunctionEPviPKcS3_S3_S3_+0x8c2): error: undefined reference to 'WebCore::DatabaseAuthorizer::createTempTrigger(WTF::String const&, WTF::String const&)'
/usr/bin/gold: /ramdisk/qt-linux-release-minimal/build/WebKitBuild/Release/Source/WebCore/release/libWebCore.a(SQLiteDatabase.o): in function WebCore::SQLiteDatabase::authorizerFunction(void*, int, char const*, char const*, char const*, char const*):SQLiteDatabase.cpp(.text._ZN7WebCore14SQLiteDatabase18authorizerFunctionEPviPKcS3_S3_S3_+0x8ff): error: undefined reference to 'WebCore::DatabaseAuthorizer::dropTable(WTF::String const&)'
/usr/bin/gold: /ramdisk/qt-linux-release-minimal/build/WebKitBuild/Release/Source/WebCore/release/libWebCore.a(SQLiteDatabase.o): in function WebCore::SQLiteDatabase::authorizerFunction(void*, int, char const*, char const*, char const*, char const*):SQLiteDatabase.cpp(.text._ZN7WebCore14SQLiteDatabase18authorizerFunctionEPviPKcS3_S3_S3_+0x92f): error: undefined reference to 'WebCore::DatabaseAuthorizer::allowDelete(WTF::String const&)'

Comment 8 Adam Barth 2012-03-06 01:48:53 PST

Fixenated in http://trac.webkit.org/changeset/109885