Bug 80356

Summary:

[WebSocket] Introduce ThreadableWebSocketChannel::SendResult

Product:

WebKit

Reporter:

Kenichi Ishibashi <bashi>

Component:

WebCore Misc.

Assignee:

Kenichi Ishibashi <bashi>

Status:

RESOLVED FIXED

Severity:

Normal

CC:

senorblanco, tkent, toyoshim, webkit.review.bot, yutak

Priority:

Version:

528+ (Nightly build)

Hardware:

Unspecified

OS:

Unspecified

Bug Depends on:

Bug Blocks:

80103

Attachments:

Description	Flags
Patch	none
Patch	none

Description Kenichi Ishibashi 2012-03-05 17:02:55 PST

https://bugs.webkit.org/show_bug.cgi?id=80103#c16

Introduce ThreadableWebsocketChannel::SendResult so that WebSocketChannel can return the result of message validation.

Comment 1 Kenichi Ishibashi 2012-03-05 17:16:54 PST

Created attachment 130243 [details]
Patch

Comment 2 Kent Tamura 2012-03-05 17:20:35 PST

Comment on attachment 130243 [details]
Patch

ok

Comment 3 Kenichi Ishibashi 2012-03-05 17:24:38 PST

Comment on attachment 130243 [details]
Patch

Thank you!

Comment 4 WebKit Review Bot 2012-03-05 18:11:33 PST

Comment on attachment 130243 [details]
Patch

Clearing flags on attachment: 130243

Committed r109832: <http://trac.webkit.org/changeset/109832>

Comment 5 WebKit Review Bot 2012-03-05 18:11:37 PST

All reviewed patches have been landed.  Closing bug.

Comment 6 Stephen White 2012-03-06 12:00:37 PST

Sorry, I had to revert this due to WebSocket test failures on Mac and Linux:  http://test-results.appspot.com/dashboards/flakiness_dashboard.html#testType=ui_tests&tests=PPAPITest.WebSocket_UtilityTextSendReceive%2CPPAPINaClTest.WebSocket_BinarySendReceive%2CPPAPINaClTest.WebSocket_UtilityBinarySendReceive%2CPPAPITest.WebSocket_BinarySendReceive%2CPPAPITest.WebSocket_TextSendReceive%2CPPAPINaClTest.WebSocket_UtilityBufferedAmount%2CPPAPINaClTest.WebSocket_CcInterfaces%2CPPAPINaClTest.WebSocket_TextSendReceive%2CPPAPITest.WebSocket_BufferedAmount%2CPPAPITest.WebSocket_CcInterfaces%2CPPAPINaClTest.WebSocket_BufferedAmount%2CPPAPITest.WebSocket_UtilityBufferedAmount%2CPPAPINaClTest.WebSocket_UtilityTextSendReceive%2CPPAPITest.WebSocket_UtilityBinarySendReceive

Rolled out in r109942.  (The rollout script failed to re-open the bug, so I'm doing it here).

Comment 7 Kenichi Ishibashi 2012-03-06 17:21:27 PST

Created attachment 130484 [details]
Patch

Comment 8 Kenichi Ishibashi 2012-03-06 17:24:52 PST

(In reply to comment #6)
> Rolled out in r109942.  (The rollout script failed to re-open the bug, so I'm doing it here).

Sorry for breaking tests. I didn't notice that WebKit/chromium/src/WebSocketImpl.cpp uses WebSocketChannel directly. Revised the patch to check the return value of WebSocketChannel::send() in WebSocketImpl.

Comment 9 WebKit Review Bot 2012-03-06 21:14:14 PST

Comment on attachment 130484 [details]
Patch

Clearing flags on attachment: 130484

Committed r110012: <http://trac.webkit.org/changeset/110012>

Comment 10 WebKit Review Bot 2012-03-06 21:14:18 PST

All reviewed patches have been landed.  Closing bug.