Summary: | WebCore::ImageBuffer.cpp has broken color table code | ||||||||||
---|---|---|---|---|---|---|---|---|---|---|---|
Product: | WebKit | Reporter: | Stephen Chenney <schenney> | ||||||||
Component: | Platform | Assignee: | Stephen Chenney <schenney> | ||||||||
Status: | RESOLVED FIXED | ||||||||||
Severity: | Normal | CC: | dglazkov, eric, krit, mitz, schenney, simon.fraser, thorton, webkit.review.bot, zherczeg, zimmermann | ||||||||
Priority: | P2 | ||||||||||
Version: | 528+ (Nightly build) | ||||||||||
Hardware: | Unspecified | ||||||||||
OS: | Unspecified | ||||||||||
Attachments: |
|
Description
Stephen Chenney
2012-03-05 13:15:15 PST
> Unfortunately, fixing this will cause massive rebaseline needs as lots of images will change imperceptibly.
Keep in mind that this code isn't used by CG/Mac, so when rebaselining, please don't change results in platform/mac.
Created attachment 146097 [details]
Patch
I have not attempted to rebaseline images, and have just set expectations for Chromium. Mac does not use this code path and is unaffected. I imagine everyone else will have some pain when this goes in, so I'll be sure to announce widely on IRC when it is imminent. I still have to make a basic ref test for this. Should have it by end of day. Comment on attachment 146097 [details] Patch View in context: https://bugs.webkit.org/attachment.cgi?id=146097&action=review r=me. Good catch! > Source/WebCore/ChangeLog:18 > + Second, the code for fill ign the table was mapping 255 to 254, thus s/ign/ignore/? Comment on attachment 146097 [details] Patch Attachment 146097 [details] did not pass chromium-ews (chromium-xvfb): Output: http://queues.webkit.org/results/12908221 New failing tests: platform/chromium/compositing/accelerated-drawing/svg-filters.html Created attachment 146205 [details]
Archive of layout-test-results from ec2-cr-linux-03
The attached test failures were seen while running run-webkit-tests on the chromium-ews.
Bot: ec2-cr-linux-03 Port: <class 'webkitpy.common.config.ports.ChromiumXVFBPort'> Platform: Linux-2.6.35-28-virtual-x86_64-with-Ubuntu-10.10-maverick
Created attachment 146297 [details]
Patch
New patch to run through ews, with the new test. Otherwise unchanged.
Committed r119831: <http://trac.webkit.org/changeset/119831> Bug still open pending test rebaselines. (In reply to comment #8) > Committed r119831: <http://trac.webkit.org/changeset/119831> The test added in this revision is failing in OS X Lion: <http://build.webkit.org/results/Lion%20Debug%20(Tests)/r119833%20(7472)/results.html>. (In reply to comment #10) > The test added in this revision is failing in OS X Lion: <http://build.webkit.org/results/Lion%20Debug%20(Tests)/r119833%20(7472)/results.html>. It seems the test should be skipped or a failure bug created for Mac. All it's doing is verifying that a basic filter operation does not modify the colors. Mac uses a different code path, which is apparently modifying the colors. Will you create the bug, or me? Committed r119841: <http://trac.webkit.org/changeset/119841> (In reply to comment #11) > (In reply to comment #10) > > The test added in this revision is failing in OS X Lion: <http://build.webkit.org/results/Lion%20Debug%20(Tests)/r119833%20(7472)/results.html>. > > It seems the test should be skipped or a failure bug created for Mac. All it's doing is verifying that a basic filter operation does not modify the colors. Mac uses a different code path, which is apparently modifying the colors. > > Will you create the bug, or me? I filed bug 88672. Committed r119860: <http://trac.webkit.org/changeset/119860> |