Bug 80284

Summary: fast/text/international/spaces-combined-in-vertical-text.html has incorrect expected results
Product: WebKit Reporter: mitz
Component: Tools / TestsAssignee: mitz
Status: RESOLVED FIXED    
Severity: Normal CC: ap, dglazkov, webkit.review.bot
Priority: P2    
Version: 528+ (Nightly build)   
Hardware: Unspecified   
OS: Unspecified   
Attachments:
Description Flags
Update the expected results ap: review+, webkit.review.bot: commit-queue-

mitz
Reported 2012-03-05 07:32:56 PST
fast/text/international/spaces-combined-in-vertical-text.html has incorrect expected results
Attachments
Update the expected results (1.13 KB, patch)
2012-03-05 07:35 PST, mitz 		ap: review+
webkit.review.bot: commit-queue-
DetailsFormatted DiffDiff
View All Add attachment proposed patch, testcase, etc.
mitz
Comment 1 2012-03-05 07:35:07 PST
Created attachment 130128 [details] Update the expected results
WebKit Review Bot
Comment 2 2012-03-05 08:13:35 PST
Comment on attachment 130128 [details] Update the expected results Attachment 130128 [details] did not pass chromium-ews (chromium-xvfb): Output: http://queues.webkit.org/results/11819030 New failing tests: fast/text/international/spaces-combined-in-vertical-text.html
mitz
Comment 3 2012-03-05 08:14:54 PST
(In reply to comment #2) > (From update of attachment 130128 [details]) > Attachment 130128 [details] did not pass chromium-ews (chromium-xvfb): > Output: http://queues.webkit.org/results/11819030 > > New failing tests: > fast/text/international/spaces-combined-in-vertical-text.html There’s nothing at <http://queues.webkit.org/results/11819030> about fast/text/international/spaces-combined-in-vertical-text.html.
mitz
Comment 4 2012-03-05 08:19:50 PST
<http://queues.webkit.org/results/11817046> does show the test failing, but doesn’t say what the results are. I suppose it produces the currently-checked-in expected results, which are clearly wrong. I can move them to platform/chromium when landing this patch, and file a bug about this apparent failure.
mitz
Comment 5 2012-03-05 08:23:42 PST
Filed bug 80293 about the Chromium failure.
Alexey Proskuryakov
Comment 6 2012-03-05 10:01:13 PST
Comment on attachment 130128 [details] Update the expected results r=me assuming that this makes the test pass in some ports. It may be more appropriate for chromium to mark the test as expected failure, not to land platform specific results.
mitz
Comment 7 2012-03-05 10:37:32 PST
(In reply to comment #6) > (From update of attachment 130128 [details]) > r=me assuming that this makes the test pass in some ports. > > It may be more appropriate for chromium to mark the test as expected failure, not to land platform specific results. Given that there’s a bug tracking the incorrectness of the results in the Chromium port, I kept them in the tree so that any change would be detected. Fixed in <http://trac.webkit.org/r109767>.
Note You need to log in before you can comment on or make changes to this bug.