Bug 80254

Summary:

Add a gyp option 'use_webaudio_ipp' to support webaudio optimization with IPP.

Product:

WebKit

Reporter:

Gao Chun <chun.gao>

Component:

Web Audio

Assignee:

Nobody <webkit-unassigned>

Status:

RESOLVED INVALID

Severity:

Normal

CC:

crogers, darin, kbr, rtoy, webkit.review.bot

Priority:

Version:

528+ (Nightly build)

Hardware:

Unspecified

OS:

Unspecified

Attachments:

Description	Flags
Patch	none
Patch	none
Patch	none
Patch	none

Gao Chun

Reported 2012-03-05 01:31:17 PST

Add a gyp option "use_webaudio_ipp" for building chromium/WebKit. To enable all macro #if USE(WEBAUDIO_IPP), use: build/gyp_chromium -Duse_webaudio_ipp=1 To disable: build/gyp_chromium -Duse_webaudio_ipp=0 or build/gyp_chromium

Attachments
Patch (2.14 KB, patch) 2012-03-05 01:50 PST, Gao Chun	no flags	Details Formatted Diff Diff
Patch (2.15 KB, patch) 2012-03-05 16:28 PST, Gao Chun	no flags	Details Formatted Diff Diff
Patch (2.19 KB, patch) 2012-03-13 02:30 PDT, Gao Chun	no flags	Details Formatted Diff Diff
Patch (2.03 KB, patch) 2012-03-29 23:27 PDT, Gao Chun	no flags	Details Formatted Diff Diff
Show Obsolete (3) View All Add attachment proposed patch, testcase, etc.

Gao Chun

Comment 1 2012-03-05 01:50:49 PST

Created attachment 130081 [details] Patch

Raymond Toy

Comment 2 2012-03-05 11:05:17 PST

Comment on attachment 130081 [details] Patch View in context: https://bugs.webkit.org/attachment.cgi?id=130081&action=review > Source/WebKit/chromium/features.gypi:158 > + # Mac OS X uses Accelerate.framework FFT by default instead of FFmpeg. nit: Maybe add additional comment here that Mac will not use IPP functions either? It's a little confusing because IPP includes more than just the FFT.

Gao Chun

Comment 3 2012-03-05 16:28:13 PST

Created attachment 130225 [details] Patch

Gao Chun

Comment 4 2012-03-05 16:31:14 PST

FIXED. Thanks! (In reply to comment #2) > (From update of attachment 130081 [details]) > View in context: https://bugs.webkit.org/attachment.cgi?id=130081&action=review > > > Source/WebKit/chromium/features.gypi:158 > > + # Mac OS X uses Accelerate.framework FFT by default instead of FFmpeg. > > nit: Maybe add additional comment here that Mac will not use IPP functions either? It's a little confusing because IPP includes more than just the FFT.

Gao Chun

Comment 5 2012-03-12 06:00:51 PDT

Comment on attachment 130081 [details] Patch View in context: https://bugs.webkit.org/attachment.cgi?id=130081&action=review >>> Source/WebKit/chromium/features.gypi:158 >>> + # Mac OS X uses Accelerate.framework FFT by default instead of FFmpeg. >> >> nit: Maybe add additional comment here that Mac will not use IPP functions either? It's a little confusing because IPP includes more than just the FFT. > > Improved, Please review again.

Raymond Toy

Comment 6 2012-03-12 09:39:20 PDT

Comment on attachment 130081 [details] Patch View in context: https://bugs.webkit.org/attachment.cgi?id=130081&action=review >>>> Source/WebKit/chromium/features.gypi:158 >>>> + # Mac OS X uses Accelerate.framework FFT by default instead of FFmpeg. >>> >>> nit: Maybe add additional comment here that Mac will not use IPP functions either? It's a little confusing because IPP includes more than just the FFT. >> >> > > Improved, Please review again. I'm sorry, but I don't see that anything changed. The comment is still the same as the original. Did you forgot to upload the change or do you want to keep the original comment?

Gao Chun

Comment 7 2012-03-13 02:30:31 PDT

Created attachment 131575 [details] Patch

Gao Chun

Comment 8 2012-03-13 04:29:48 PDT

(In reply to comment #6) > (From update of attachment 130081 [details]) > View in context: https://bugs.webkit.org/attachment.cgi?id=130081&action=review > > >>>> Source/WebKit/chromium/features.gypi:158 > >>>> + # Mac OS X uses Accelerate.framework FFT by default instead of FFmpeg. > >>> > >>> nit: Maybe add additional comment here that Mac will not use IPP functions either? It's a little confusing because IPP includes more than just the FFT. > >> > >> > > > > Improved, Please review again. > > I'm sorry, but I don't see that anything changed. The comment is still the same as the original. Did you forgot to upload the change or do you want to keep the original comment? New patch has been committed, pls review again, thanks!

Raymond Toy

Comment 9 2012-03-13 09:34:13 PDT

Comment on attachment 131575 [details] Patch This looks good, but I'm not really familiar with gyp files.

Chris Rogers

Comment 10 2012-03-29 15:16:13 PDT

Comment on attachment 131575 [details] Patch View in context: https://bugs.webkit.org/attachment.cgi?id=131575&action=review > Source/WebKit/chromium/features.gypi:155 > + 'use_skia%': 1, I assume this use-skia change was not supposed to be part of this patch?

Gao Chun

Comment 11 2012-03-29 23:27:01 PDT

Created attachment 134730 [details] Patch

Gao Chun

Comment 12 2012-03-29 23:31:32 PDT

(In reply to comment #10) > (From update of attachment 131575 [details]) > View in context: https://bugs.webkit.org/attachment.cgi?id=131575&action=review > > > Source/WebKit/chromium/features.gypi:155 > > + 'use_skia%': 1, > > I assume this use-skia change was not supposed to be part of this patch? I have removed this and uploaded a new patch. Thanks.

Gao Chun

Comment 13 2012-04-12 22:05:57 PDT

Any feedback?

Darin Adler

Comment 14 2013-05-13 18:32:56 PDT

Chromium-specific, it seems.

Note You need to log in before you can comment on or make changes to this bug.