Bug 80249 – Qt API test buildstep throws exception after buildmaster update

• Component: Tools / Tests
• Status: RESOLVED FIXED

[Csaba Osztrogonác]

The problem is that configuration_pretty is set by RunQtAPITests.start(),
but it is used by RunQtAPITests.command class member. It wasn't problem
with the previous buildmaster, but the new master throws exception:

Traceback (most recent call last):
  File "/opt/local/Library/Frameworks/Python.framework/Versions/2.7/lib/python2.7/site-packages/twisted/internet/defer.py", line 134, in maybeDeferred
    result = f(*args, **kw)
  File "/opt/local/Library/Frameworks/Python.framework/Versions/2.7/lib/python2.7/site-packages/buildbot/process/buildstep.py", line 518, in startStep
    d.addCallback(self._startStep_2)
  File "/opt/local/Library/Frameworks/Python.framework/Versions/2.7/lib/python2.7/site-packages/twisted/internet/defer.py", line 298, in addCallback
    callbackKeywords=kw)
  File "/opt/local/Library/Frameworks/Python.framework/Versions/2.7/lib/python2.7/site-packages/twisted/internet/defer.py", line 287, in addCallbacks
    self._runCallbacks()
--- <exception caught here> ---
  File "/opt/local/Library/Frameworks/Python.framework/Versions/2.7/lib/python2.7/site-packages/twisted/internet/defer.py", line 545, in _runCallbacks
    current.result = callback(current.result, *args, **kw)
  File "/opt/local/Library/Frameworks/Python.framework/Versions/2.7/lib/python2.7/site-packages/buildbot/process/buildstep.py", line 560, in _startStep_2
    setattr(self, renderable, self.build.render(getattr(self, renderable)))
  File "/opt/local/Library/Frameworks/Python.framework/Versions/2.7/lib/python2.7/site-packages/buildbot/process/properties.py", line 177, in render
    return props.render(value)
  File "/opt/local/Library/Frameworks/Python.framework/Versions/2.7/lib/python2.7/site-packages/buildbot/process/properties.py", line 137, in render
    return renderable.getRenderingFor(self)
  File "/opt/local/Library/Frameworks/Python.framework/Versions/2.7/lib/python2.7/site-packages/buildbot/process/properties.py", line 351, in getRenderingFor
    return [ build.render(e) for e in self.value ]
  File "/opt/local/Library/Frameworks/Python.framework/Versions/2.7/lib/python2.7/site-packages/buildbot/process/properties.py", line 137, in render
    return renderable.getRenderingFor(self)
  File "/opt/local/Library/Frameworks/Python.framework/Versions/2.7/lib/python2.7/site-packages/buildbot/process/properties.py", line 287, in getRenderingFor
    s = self.fmtstring % pmap
  File "/opt/local/Library/Frameworks/Python.framework/Versions/2.7/lib/python2.7/site-packages/buildbot/process/properties.py", line 244, in __getitem__
    rv = properties[key]
  File "/opt/local/Library/Frameworks/Python.framework/Versions/2.7/lib/python2.7/site-packages/buildbot/process/properties.py", line 71, in __getitem__
    rv = self.properties[name][0]
exceptions.KeyError: 'configuration_pretty'

[Csaba Osztrogonác]

Created attachment 130069 [details]
proposed workaround

We should disable API tests on the Qt bot
until we find the proper fix for it.

[Zoltan Herczeg]

Comment on attachment 130069 [details]
proposed workaround

View in context: https://bugs.webkit.org/attachment.cgi?id=130069&action=review

> Tools/BuildSlaveSupport/build.webkit.org-config/master.cfg:762
> +# https://bugs.webkit.org/show_bug.cgi?id=80249

Mention here that this is a temporary change.

[Csaba Osztrogonác]

Comment on attachment 130069 [details]
proposed workaround

Clearing flags on attachment: 130069

Committed r109726: <http://trac.webkit.org/changeset/109726>

[Kristóf Kosztyó]

Created attachment 130105 [details]
proposed fix

[Csaba Osztrogonác]

Comment on attachment 130105 [details]
proposed fix

r=me, but cq-, because we have to enable API tests again after this fix.

[Csaba Osztrogonác]

Comment on attachment 130105 [details]
proposed fix

Landed in http://trac.webkit.org/changeset/109901