Bug 80179

Summary:

[Qt] Add support for vertical sliders in mobile theme

Product:

WebKit

Reporter:

Pierre Rossi <pierre.rossi>

Component:

New Bugs

Assignee:

Pierre Rossi <pierre.rossi>

Status:

RESOLVED FIXED

Severity:

Normal

CC:

dglazkov, webkit.review.bot

Priority:

Version:

528+ (Nightly build)

Hardware:

Unspecified

OS:

Unspecified

Attachments:

Description	Flags
Patch	hausmann: review+, webkit.review.bot: commit-queue-

Description Pierre Rossi 2012-03-02 12:16:51 PST

[Qt] Add support for vertical sliders in mobile theme

Comment 1 Pierre Rossi 2012-03-02 12:29:32 PST

Created attachment 129939 [details]
Patch

Comment 2 WebKit Review Bot 2012-03-02 15:16:19 PST

Comment on attachment 129939 [details]
Patch

Attachment 129939 [details] did not pass chromium-ews (chromium-xvfb):
Output: http://queues.webkit.org/results/11800151

New failing tests:
editing/selection/select-line-break-with-opposite-directionality.html

Comment 3 Simon Hausmann 2012-03-07 11:45:32 PST

Comment on attachment 129939 [details]
Patch

View in context: https://bugs.webkit.org/attachment.cgi?id=129939&action=review

> Source/WebCore/platform/qt/RenderThemeQtMobile.cpp:471
> +    const int horizontalBorder = (vertical ? rect.width() / 4 : 0);
> +    const int verticalBorder = (vertical ? 0 : rect.height() / 4);

I personally tend to leave out the extra pair of parentheses here.

Comment 4 Pierre Rossi 2012-03-14 12:46:15 PDT

Committed r110730: <http://trac.webkit.org/changeset/110730>