Bug 80166

Summary: Web Inspector: InspectorCounters mechanism should be thread-safe
Product: WebKit Reporter: Yury Semikhatsky <yurys>
Component: Web Inspector (Deprecated)Assignee: Yury Semikhatsky <yurys>
Status: RESOLVED FIXED    
Severity: Normal CC: abarth, apavlov, bweinstein, japhet, joepeck, keishi, loislo, pfeldman, pmuellr, rik, timothy, webkit.review.bot, yurys
Priority: P2    
Version: 528+ (Nightly build)   
Hardware: All   
OS: All   
Attachments:
Description Flags
Patch
none
Patch
none
Patch pfeldman: review+

Description Yury Semikhatsky 2012-03-02 09:06:33 PST 
There are some counters which make sense for workers as well (e.g. event listener count) and since workers run in their own threads it should be safe to increment/decrement counters from there.
Comment 1 Yury Semikhatsky 2012-03-02 09:08:57 PST 
Created attachment 129910 [details]
Patch
Comment 2 Yury Semikhatsky 2012-03-02 09:10:52 PST 
Dromaeo results for Chromium run
with the patch applied: http://dromaeo.com/?id=164681
and without it: http://dromaeo.com/?id=164673
Comment 3 Early Warning System Bot 2012-03-02 09:23:04 PST 
Comment on attachment 129910 [details]
Patch

Attachment 129910 [details] did not pass qt-ews (qt):
Output: http://queues.webkit.org/results/11802009
Comment 4 Build Bot 2012-03-02 09:28:08 PST 
Comment on attachment 129910 [details]
Patch

Attachment 129910 [details] did not pass win-ews (win):
Output: http://queues.webkit.org/results/11797038
Comment 5 Pavel Feldman 2012-03-02 09:29:59 PST 
(In reply to comment #2)
> Dromaeo results for Chromium run
> with the patch applied: http://dromaeo.com/?id=164681
> and without it: http://dromaeo.com/?id=164673

So you are saying it got faster?

Sounds like you are breaking ews.
Comment 6 Pavel Feldman 2012-03-02 09:30:34 PST 
Comment on attachment 129910 [details]
Patch

r- for breaking build.
Comment 7 Yury Semikhatsky 2012-03-05 01:07:12 PST 
(In reply to comment #5)
> (In reply to comment #2)
> > Dromaeo results for Chromium run
> > with the patch applied: http://dromaeo.com/?id=164681
> > and without it: http://dromaeo.com/?id=164673
> 
> So you are saying it got faster?
> 
Of cause not, it just one of the sampling errors. In two other runs the results were about the same:
http://dromaeo.com/?id=164676
http://dromaeo.com/?id=164678

> Sounds like you are breaking ews.
Will fix.
Comment 8 Yury Semikhatsky 2012-03-05 06:05:30 PST 
Created attachment 130107 [details]
Patch
Comment 9 Yury Semikhatsky 2012-03-06 07:54:12 PST 
Created attachment 130385 [details]
Patch
Comment 10 Yury Semikhatsky 2012-03-06 08:20:58 PST 
Committed r109922: <http://trac.webkit.org/changeset/109922>