Bug 80166

Summary:

Web Inspector: InspectorCounters mechanism should be thread-safe

Product:

WebKit

Reporter:

Yury Semikhatsky <yurys>

Component:

Web Inspector (Deprecated)

Assignee:

Yury Semikhatsky <yurys>

Status:

RESOLVED FIXED

Severity:

Normal

CC:

abarth, apavlov, bweinstein, japhet, joepeck, keishi, loislo, pfeldman, pmuellr, rik, timothy, webkit.review.bot, yurys

Priority:

Version:

528+ (Nightly build)

Hardware:

All

OS:

All

Attachments:

Description	Flags
Patch	none
Patch	none
Patch	pfeldman: review+

Yury Semikhatsky

Reported 2012-03-02 09:06:33 PST

There are some counters which make sense for workers as well (e.g. event listener count) and since workers run in their own threads it should be safe to increment/decrement counters from there.

Attachments
Patch (12.26 KB, patch) 2012-03-02 09:08 PST, Yury Semikhatsky	no flags	Details Formatted Diff Diff
Patch (12.45 KB, patch) 2012-03-05 06:05 PST, Yury Semikhatsky	no flags	Details Formatted Diff Diff
Patch (14.98 KB, patch) 2012-03-06 07:54 PST, Yury Semikhatsky	pfeldman: review+	Details Formatted Diff Diff
Show Obsolete (2) View All Add attachment proposed patch, testcase, etc.

Yury Semikhatsky

Comment 1 2012-03-02 09:08:57 PST

Created attachment 129910 [details] Patch

Yury Semikhatsky

Comment 2 2012-03-02 09:10:52 PST

Dromaeo results for Chromium run with the patch applied: http://dromaeo.com/?id=164681 and without it: http://dromaeo.com/?id=164673

Early Warning System Bot

Comment 3 2012-03-02 09:23:04 PST

Comment on attachment 129910 [details] Patch Attachment 129910 [details] did not pass qt-ews (qt): Output: http://queues.webkit.org/results/11802009

Build Bot

Comment 4 2012-03-02 09:28:08 PST

Comment on attachment 129910 [details] Patch Attachment 129910 [details] did not pass win-ews (win): Output: http://queues.webkit.org/results/11797038

Pavel Feldman

Comment 5 2012-03-02 09:29:59 PST

(In reply to comment #2) > Dromaeo results for Chromium run > with the patch applied: http://dromaeo.com/?id=164681 > and without it: http://dromaeo.com/?id=164673 So you are saying it got faster? Sounds like you are breaking ews.

Pavel Feldman

Comment 6 2012-03-02 09:30:34 PST

Comment on attachment 129910 [details] Patch r- for breaking build.

Yury Semikhatsky

Comment 7 2012-03-05 01:07:12 PST

(In reply to comment #5) > (In reply to comment #2) > > Dromaeo results for Chromium run > > with the patch applied: http://dromaeo.com/?id=164681 > > and without it: http://dromaeo.com/?id=164673 > > So you are saying it got faster? > Of cause not, it just one of the sampling errors. In two other runs the results were about the same: http://dromaeo.com/?id=164676 http://dromaeo.com/?id=164678 > Sounds like you are breaking ews. Will fix.

Yury Semikhatsky

Comment 8 2012-03-05 06:05:30 PST

Created attachment 130107 [details] Patch

Yury Semikhatsky

Comment 9 2012-03-06 07:54:12 PST

Created attachment 130385 [details] Patch

Yury Semikhatsky

Comment 10 2012-03-06 08:20:58 PST

Committed r109922: <http://trac.webkit.org/changeset/109922>

Note You need to log in before you can comment on or make changes to this bug.