Summary: | BlackBerryPlatformScreen.h API has been updated. Reflect those changes in our usage. | ||||||||||
---|---|---|---|---|---|---|---|---|---|---|---|
Product: | WebKit | Reporter: | Adam Treat <manyoso> | ||||||||
Component: | WebKit BlackBerry | Assignee: | Adam Treat <manyoso> | ||||||||
Status: | RESOLVED FIXED | ||||||||||
Severity: | Normal | CC: | tonikitoo, webkit.review.bot | ||||||||
Priority: | P2 | ||||||||||
Version: | 528+ (Nightly build) | ||||||||||
Hardware: | Unspecified | ||||||||||
OS: | Unspecified | ||||||||||
Attachments: |
|
Description
Adam Treat
2012-03-02 07:36:55 PST
Created attachment 129900 [details]
Fix
Comment on attachment 129900 [details] Fix View in context: https://bugs.webkit.org/attachment.cgi?id=129900&action=review > Source/WebCore/ChangeLog:9 > + Reviewed by Jakob Petsovits. mark it as internally reviewed by Jakob. Created attachment 129905 [details]
Version that applies to trunk
I changed Jakob to an internal reviewer and made a patch that applies against trunk. The reason the other one didn't apply is it included a hunk against a file that has not been upstreamed yet.
Comment on attachment 129905 [details] Version that applies to trunk Rejecting attachment 129905 [details] from commit-queue. Failed to run "['/mnt/git/webkit-commit-queue/Tools/Scripts/webkit-patch', '--status-host=queues.webkit.org', '-..." exit_code: 1 Atonio Gomes found in /mnt/git/webkit-commit-queue/Source/WebCore/ChangeLog does not appear to be a valid reviewer according to committers.py. ERROR: /mnt/git/webkit-commit-queue/Source/WebCore/ChangeLog neither lists a valid reviewer nor contains the string "Unreviewed" or "Rubber stamp" (case insensitive). Full output: http://queues.webkit.org/results/11803017 Created attachment 129919 [details]
Version with right spelling of 'Antonio'
Comment on attachment 129919 [details] Version with right spelling of 'Antonio' Clearing flags on attachment: 129919 Committed r109592: <http://trac.webkit.org/changeset/109592> All reviewed patches have been landed. Closing bug. |