Summary: | [EFL] Add OwnPtr specialization for Ecore_Timer | ||||||||||||
---|---|---|---|---|---|---|---|---|---|---|---|---|---|
Product: | WebKit | Reporter: | YoungTaeck Song <youngtaeck.song> | ||||||||||
Component: | WebKit EFL | Assignee: | Nobody <webkit-unassigned> | ||||||||||
Status: | RESOLVED FIXED | ||||||||||||
Severity: | Normal | CC: | gyuyoung.kim, lucas.de.marchi, rakuco, ryuan.choi, webkit.review.bot | ||||||||||
Priority: | P2 | ||||||||||||
Version: | 528+ (Nightly build) | ||||||||||||
Hardware: | Other | ||||||||||||
OS: | Linux | ||||||||||||
Bug Depends on: | |||||||||||||
Bug Blocks: | 62777 | ||||||||||||
Attachments: |
|
Description
YoungTaeck Song
2012-03-02 00:12:29 PST
Created attachment 129833 [details]
patch
How do you think about applying this in SharedTimerEfl.cpp and somewhere Ecore_Timer is used ? (In reply to comment #2) > How do you think about applying this in SharedTimerEfl.cpp and somewhere Ecore_Timer is used ? This patch for RunLoopEfl.cpp. Please see https://bugs.webkit.org/attachment.cgi?id=129848&action=review. So I think it's not suitable to using SharedTimerEfl.cpp Created attachment 130057 [details]
Patch
(In reply to comment #2) > How do you think about applying this in SharedTimerEfl.cpp and somewhere Ecore_Timer is used ? Sorry, Ryuan. I misunderstood your intentions. I changed SharedTimerEfl.cpp to use OwnPtr<Ecore_timer> at next patch. (In reply to comment #5) > (In reply to comment #2) > > How do you think about applying this in SharedTimerEfl.cpp and somewhere Ecore_Timer is used ? > > Sorry, Ryuan. I misunderstood your intentions. > I changed SharedTimerEfl.cpp to use OwnPtr<Ecore_timer> at next patch. You are missing WebCore's ChangeLog. Created attachment 130066 [details]
Patch
(In reply to comment #7) > Created an attachment (id=130066) [details] > Patch Looks good to me. Comment on attachment 130066 [details] Patch View in context: https://bugs.webkit.org/attachment.cgi?id=130066&action=review > Source/WebCore/platform/efl/SharedTimerEfl.cpp:41 > -static Ecore_Timer *_sharedTimer = 0; > +static OwnPtr<Ecore_Timer> sharedTimer; Declaring a static object like this makes the code prone to all sorts of problems, since you can't guarantee when this object will be initialized. Either keep the old version, or use the DEFINE_STATIC_LOCAL macro to make sure the object is created on first use. Created attachment 130247 [details]
Patch
(In reply to comment #9) > (From update of attachment 130066 [details]) > View in context: https://bugs.webkit.org/attachment.cgi?id=130066&action=review > > > Source/WebCore/platform/efl/SharedTimerEfl.cpp:41 > > -static Ecore_Timer *_sharedTimer = 0; > > +static OwnPtr<Ecore_Timer> sharedTimer; > > Declaring a static object like this makes the code prone to all sorts of problems, since you can't guarantee when this object will be initialized. Either keep the old version, or use the DEFINE_STATIC_LOCAL macro to make sure the object is created on first use. Thanks for your review. We decided to keep the old version. Comment on attachment 130247 [details]
Patch
Looks OK to me.
Comment on attachment 130247 [details]
Patch
LGTM.
Comment on attachment 130247 [details] Patch Clearing flags on attachment: 130247 Committed r110876: <http://trac.webkit.org/changeset/110876> All reviewed patches have been landed. Closing bug. |