Bug 80109

Summary:

[Forms] HTMLFieldSetElement.idl doesn't have type attribute.

Product:

WebKit

Reporter:

yosin

Component:

Forms

Assignee:

yosin

Status:

RESOLVED FIXED

Severity:

Normal

CC:

abarth, morrita, ojan, tkent, webkit.review.bot

Priority:

Version:

528+ (Nightly build)

Hardware:

Unspecified

OS:

Unspecified

URL:

http://jsfiddle.net/2yYDD/

Bug Depends on:

Bug Blocks:

19264

Attachments:

Description	Flags
Patch 1	none
Patch 2	none
Patch 3	none

Description yosin 2012-03-01 23:42:59 PST

See http://www.whatwg.org/specs/web-apps/current-work/multipage/forms.html#the-fieldset-element

Adding "type" attribute to IDL is easy, because class HTMLFieldSetElement has disabled method inherited from HTMLFormControlElement.

Comment 1 yosin 2012-03-02 02:12:57 PST

Created attachment 129858 [details]
Patch 1

Comment 2 yosin 2012-03-04 19:30:29 PST

Created attachment 130045 [details]
Patch 2

Comment 3 Hajime Morrita 2012-03-05 01:05:05 PST

Comment on attachment 130045 [details]
Patch 2

View in context: https://bugs.webkit.org/attachment.cgi?id=130045&action=review

Looks ok. Could you address tiny bits above before landing?

> Source/WebCore/html/HTMLFieldSetElement.idl:26
> +

Nit: You don't need enclosing blank lines.

Comment 4 yosin 2012-03-05 01:32:16 PST

Blank lines around "readonly attribute DOMString type;" is intentional to make our IDL looks similar to the specification in

http://www.whatwg.org/specs/web-apps/current-work/multipage/forms.html#the-fieldset-element

Here is excerpt from the specification:

interface HTMLFieldSetElement : HTMLElement {
           attribute boolean disabled;
  readonly attribute HTMLFormElement? form;
           attribute DOMString name;

  readonly attribute DOMString type;

  readonly attribute HTMLFormControlsCollection elements;

  readonly attribute boolean willValidate;
  readonly attribute ValidityState validity;
  readonly attribute DOMString validationMessage;
  boolean checkValidity();
  void setCustomValidity(DOMString error);
};

Comment 5 WebKit Review Bot 2012-03-05 19:33:30 PST

Comment on attachment 130045 [details]
Patch 2

Rejecting attachment 130045 [details] from commit-queue.

Failed to run "['/mnt/git/webkit-commit-queue/Tools/Scripts/webkit-patch', '--status-host=queues.webkit.org', '-..." exit_code: 2

Last 500 characters of output:
t/git/webkit-commit-queue/Source/WebKit/chromium/v8 --revision 10875 --non-interactive --force --accept theirs-conflict --ignore-externals' in '/mnt/git/webkit-commit-queue/Source/WebKit/chromium'
47>At revision 10875.

________ running '/usr/bin/python tools/clang/scripts/update.py --mac-only' in '/mnt/git/webkit-commit-queue/Source/WebKit/chromium'

________ running '/usr/bin/python gyp_webkit' in '/mnt/git/webkit-commit-queue/Source/WebKit/chromium'
Updating webkit projects from gyp files...

Full output: http://queues.webkit.org/results/11835136

Comment 6 yosin 2012-03-05 19:40:52 PST

Created attachment 130270 [details]
Patch 3

Comment 7 WebKit Review Bot 2012-03-05 20:55:09 PST

Comment on attachment 130270 [details]
Patch 3

Clearing flags on attachment: 130270

Committed r109846: <http://trac.webkit.org/changeset/109846>

Comment 8 WebKit Review Bot 2012-03-05 20:55:14 PST

All reviewed patches have been landed.  Closing bug.