| Summary: | fix negative flexing in auto sized columns | ||||||||||||
|---|---|---|---|---|---|---|---|---|---|---|---|---|---|
| Product: | WebKit | Reporter: | Tony Chang <tony> | ||||||||||
| Component: | New Bugs | Assignee: | Tony Chang <tony> | ||||||||||
| Status: | RESOLVED FIXED | ||||||||||||
| Severity: | Normal | CC: | hyatt, ojan | ||||||||||
| Priority: | P2 | ||||||||||||
| Version: | 528+ (Nightly build) | ||||||||||||
| Hardware: | Unspecified | ||||||||||||
| OS: | Unspecified | ||||||||||||
| Bug Depends on: | |||||||||||||
| Bug Blocks: | 62048 | ||||||||||||
| Attachments: |
|
||||||||||||
|
Description
Tony Chang
2012-03-01 16:46:36 PST
Created attachment 129772 [details]
Patch
I don't love the name resolveLogicalHeightUsing because it's very similar to computeLogicalHeightUsing. Suggestions welcome. Comment on attachment 129772 [details] Patch View in context: https://bugs.webkit.org/attachment.cgi?id=129772&action=review So much copy paste from RenderBox. :( I don't see a better way though. > Source/WebCore/rendering/RenderFlexibleBox.cpp:503 > +LayoutUnit RenderFlexibleBox::resolveLogicalHeightUsing(const Length& height) computeContentLogicalHeightUsing? Created attachment 129779 [details]
Patch
Created attachment 130646 [details]
Patch
(In reply to comment #5) > Created an attachment (id=130646) [details] > Patch rebasing Created attachment 131922 [details]
Patch
Comment on attachment 131922 [details]
Patch
Ojan, can you take another look? Now it's just a small amount of code modified from computeLogicalHeight (computeContentLogicalHeightUsing is now in RenderBox), but it's different enough that I don't think there's a good way to refactor to share code.
Committed r110772: <http://trac.webkit.org/changeset/110772> |