Bug 80041

Summary: Add a generic way to protect Nodes from getting destroyed during DOM mutations
Product: WebKit Reporter: Ojan Vafai <ojan>
Component: New BugsAssignee: Ojan Vafai <ojan>
Status: NEW    
Severity: Normal CC: abarth, inferno, jschuh, morrita, rniwa
Priority: P2    
Version: 528+ (Nightly build)   
Hardware: Unspecified   
OS: Unspecified   
Attachments:
Description Flags
Patch
none
another performance test none

Ojan Vafai
Reported 2012-03-01 12:32:43 PST
Add a generic way to protect Nodes from getting destroyed during DOM mutations
Attachments
Patch (21.29 KB, patch)
2012-03-01 12:36 PST, Ojan Vafai 		no flags
DetailsFormatted DiffDiff
another performance test (1.20 KB, text/html)
2012-03-01 15:32 PST, Ojan Vafai 		no flags
Details
View All Add attachment proposed patch, testcase, etc.
Ojan Vafai
Comment 1 2012-03-01 12:36:00 PST
Created attachment 129732 [details] Patch
Ojan Vafai
Comment 2 2012-03-01 15:32:39 PST
Created attachment 129759 [details] another performance test
Hajime Morrita
Comment 3 2012-03-01 17:16:30 PST
It looks we often know how many nodes are possibly deleted during the scope. In that case, we could pre-allocate the array statically using template. Even when we need some dynamic allocation, we could reserve such storage on the scope initialization.
Abhishek Arya
Comment 4 2012-03-02 11:09:26 PST
We have refptr protects in appendChild, insertBefore and replaceChild. do you want to fix those? check out http://trac.webkit.org/changeset/106972. Please do make sure to run the tests in those changeset with libgmalloc after your change.
Note You need to log in before you can comment on or make changes to this bug.