| Summary: | REGRESSION (r108956): Safari Webpage Preview Fetcher crashes in WebCore::localizedString() when using a WebKit nightly build | ||||||
|---|---|---|---|---|---|---|---|
| Product: | WebKit | Reporter: | mitz | ||||
| Component: | Platform | Assignee: | mitz | ||||
| Status: | RESOLVED FIXED | ||||||
| Severity: | Normal | CC: | webkit.review.bot | ||||
| Priority: | P1 | Keywords: | InRadar, Regression | ||||
| Version: | 528+ (Nightly build) | ||||||
| Hardware: | Unspecified | ||||||
| OS: | Unspecified | ||||||
| Attachments: |
|
||||||
|
Description
mitz
2012-03-01 10:07:09 PST
Created attachment 129721 [details]
Null-check the return value of CFBundleGetBundleWithIdentifier()
Attachment 129721 [details] did not pass style-queue:
Failed to run "['Tools/Scripts/check-webkit-style', '--diff-files', u'ChangeLog', u'LayoutTests/ChangeLog', u'La..." exit_code: 1
Traceback (most recent call last):
File "Tools/Scripts/check-webkit-style", line 48, in <module>
sys.exit(CheckWebKitStyle().main())
File "/mnt/git/webkit-style-queue/Tools/Scripts/webkitpy/style/main.py", line 154, in main
patch_checker.check(patch)
File "/mnt/git/webkit-style-queue/Tools/Scripts/webkitpy/style/patchreader.py", line 66, in check
self._text_file_reader.process_file(file_path=path, line_numbers=line_numbers)
File "/mnt/git/webkit-style-queue/Tools/Scripts/webkitpy/style/filereader.py", line 130, in process_file
self._processor.process(lines, file_path, **kwargs)
File "/mnt/git/webkit-style-queue/Tools/Scripts/webkitpy/style/checker.py", line 838, in process
checker.check(lines)
File "/mnt/git/webkit-style-queue/Tools/Scripts/webkitpy/style/checkers/test_expectations.py", line 103, in check
overrides = self._port_obj.test_expectations_overrides()
AttributeError: 'NoneType' object has no attribute 'test_expectations_overrides'
If any of these errors are false positives, please file a bug against check-webkit-style.
Comment on attachment 129721 [details] Null-check the return value of CFBundleGetBundleWithIdentifier() View in context: https://bugs.webkit.org/attachment.cgi?id=129721&action=review > Source/WebCore/platform/mac/LocalizedStringsMac.cpp:55 > + else > + result = notFound; > > ASSERT_WITH_MESSAGE(result.get() != notFound, "could not find localizable string %s in bundle", key); You are gonna hit the assert every time. Better move the assert in the if() Fixed in <http://trac.webkit.org/r109497>. |