Bug 79838 – perf-o-matic: generate dashboard images using Google Chart Tools

• Component: WebKit Website
• Status: RESOLVED FIXED

[Ryosuke Niwa]

webkit-perf.appspot.com/ doesn't load anymore because it's got way too many iframes. We need to replace all these iframes by actual images.

Thankfully, Google chart tools generate png images that we can then cache:
http://code.google.com/apis/chart/image/docs/gallery/line_charts.html

[Ryosuke Niwa]

Created attachment 129338 [details]
First patch; generate images

[Ryosuke Niwa]

Comment on attachment 129338 [details]
First patch; generate images

View in context: https://bugs.webkit.org/attachment.cgi?id=129338&action=review

> Websites/webkit-perf.appspot.com/json_generators.py:217
> +            'cht': 'lxy',  # Specify with X and Y coordinates
> +            'chxt': 'x,y',  # Display both X and Y axies
> +            'chxl': '0:|' + '|'.join([date.strftime('%b %d') for date in dates]),  # X-axis labels
> +            'chxr': '1,0,%f,%f' % (int(y_max + 0.5), y_axis_label_step),  # Y-axis range: min=0, max, step
> +            'chds': '%f,%f,%f,%f' % (start_timestamp, end_timestamp, 0, y_max),  # X, Y data range
> +            'chxs': '1,676767,11.167,0,l,676767', # Y-axis label: 1,color,font-size,centerd on tick,axis line/no ticks, tick color
> +            'chs': '360x240', # Image size: 360px by 240px
> +            'chco': 'ff0000', # Plot line color
> +            'chg': '%f,%f,0,0' % (100 / (len(dates) - 1), y_grid_step), # X, Y grid line step sizes - max for X is 100.
> +            'chls': '3', # Line thickness
> +            'chf': 'bg,s,eff6fd', # Transparent background
> +            'chd': 't:' + ','.join([str(x) for x in chart_data_x]) + '|' + ','.join([str(y) for y in chart_data_y]), # X, Y data

I know it looks horrible :( but there isn't much I can do unfortunately...

[WebKit Review Bot]

Attachment 129338 [details] did not pass style-queue:

Failed to run "['Tools/Scripts/check-webkit-style', '--diff-files', u'ChangeLog', u'Websites/webkit-perf.appspot..." exit_code: 1
Websites/webkit-perf.appspot.com/json_generators.py:211:  at least two spaces before inline comment  [pep8/E261] [5]
Total errors found: 1 in 6 files


If any of these errors are false positives, please file a bug against check-webkit-style.

[Ryosuke Niwa]

Created attachment 129341 [details]
Make the style bot happy

[Hajime Morrita]

Comment on attachment 129341 [details]
Make the style bot happy

I don't think we need to save images on appengine. We can just redirect to the chart API image URL.
I'm pretty sure they have their own cache (or something for speed) and serve the image well.

[Ryosuke Niwa]

(In reply to comment #5)
> (From update of attachment 129341 [details])
> I don't think we need to save images on appengine. We can just redirect to the chart API image URL.
> I'm pretty sure they have their own cache (or something for speed) and serve the image well.

You think so? FYI, we'll be making something like 300 chart requests per page load.

[Hajime Morrita]

Comment on attachment 129341 [details]
Make the style bot happy

Looks good. Let's try.

[Ryosuke Niwa]

Comment on attachment 129341 [details]
Make the style bot happy

Clearing flags on attachment: 129341

Committed r109190: <http://trac.webkit.org/changeset/109190>

[Ryosuke Niwa]

All reviewed patches have been landed.  Closing bug.