Bug 79804

Summary:

[GTK] Remove virtual methods of WebKitDownload signals in WebKit2 GTK+ API

Product:

WebKit

Reporter:

Carlos Garcia Campos <cgarcia>

Component:

WebKit2

Assignee:

Nobody <webkit-unassigned>

Status:

RESOLVED FIXED

Severity:

Normal

CC:

gustavo, pnormand, webkit.review.bot

Priority:

Keywords:

Gtk

Version:

528+ (Nightly build)

Hardware:

OS:

Linux

Attachments:

Description	Flags
Patch	mrobinson: review+

Description Carlos Garcia Campos 2012-02-28 09:05:18 PST

That comes from the first patch that followed the approach of the first LoaderClient implementation. With current implementation download signals, except decide-destination, don't need to be true_handled, and they won't have a default handler implementation. Also the download object is not supposed to be inheritable, since instances are created privately by the WebContext, so it's not possible to override the virtual methods in derived classes.

Comment 1 Carlos Garcia Campos 2012-02-28 09:07:42 PST

Created attachment 129274 [details]
Patch

Comment 2 WebKit Review Bot 2012-02-28 09:10:29 PST

Thanks for the patch. If this patch contains new public API please make sure it follows the guidelines for new WebKit2 GTK+ API. See http://trac.webkit.org/wiki/WebKitGTK/AddingNewWebKit2API

Comment 3 Carlos Garcia Campos 2012-02-28 09:57:05 PST

Committed r109117: <http://trac.webkit.org/changeset/109117>