Bug 79761

Summary: Align InlineBox::m_expansion to a byte boundary
Product: WebKit Reporter: Kenichi Ishibashi <bashi>
Component: Layout and RenderingAssignee: Kenichi Ishibashi <bashi>
Status: RESOLVED FIXED    
Severity: Normal CC: morrita, webkit.review.bot
Priority: P2    
Version: 528+ (Nightly build)   
Hardware: Unspecified   
OS: Unspecified   
Attachments:
Description Flags
Patch
none
Patch for landing none

Description Kenichi Ishibashi 2012-02-28 00:39:28 PST 
Valgrind memcheck complains that TextRun::expantion() is uninitialized.
http://code.google.com/p/chromium/issues/detail?id=115808#c5

TextRun::m_expansion is initialized by InlineBox::m_expansion to InlineTextBox::constructTextRun(), which is initialized to zero. After some investigation, I noticed that m_expansion doesn't align to a byte boundary. This caused the valgrind errors.
Comment 1 Kenichi Ishibashi 2012-02-28 00:50:18 PST 
Created attachment 129210 [details]
Patch
Comment 2 Kenichi Ishibashi 2012-02-28 00:54:13 PST 
(In reply to comment #1)
> Created an attachment (id=129210) [details]
> Patch

I checked:
- Valgrind memecheck doesn't detect uninitialized value references in HarfBuzzShaperBase.
- The size of InlineBox is the same

Morrita-san, could you please review?
Comment 3 Hajime Morrita 2012-02-29 01:43:05 PST 
Comment on attachment 129210 [details]
Patch

Could you claim the fact about the sizeof(InlineBox) in ChangeLog?
Comment 4 Kenichi Ishibashi 2012-02-29 03:07:11 PST 
Created attachment 129427 [details]
Patch for landing
Comment 5 WebKit Review Bot 2012-02-29 09:07:10 PST 
Comment on attachment 129427 [details]
Patch for landing

Clearing flags on attachment: 129427

Committed r109220: <http://trac.webkit.org/changeset/109220>
Comment 6 WebKit Review Bot 2012-02-29 09:07:15 PST 
All reviewed patches have been landed.  Closing bug.