Bug 79761

Summary: Align InlineBox::m_expansion to a byte boundary
Product: WebKit Reporter: Kenichi Ishibashi <bashi>
Component: Layout and RenderingAssignee: Kenichi Ishibashi <bashi>
Status: RESOLVED FIXED    
Severity: Normal CC: morrita, webkit.review.bot
Priority: P2    
Version: 528+ (Nightly build)   
Hardware: Unspecified   
OS: Unspecified   
Attachments:
Description Flags
Patch
none
Patch for landing none

Kenichi Ishibashi
Reported 2012-02-28 00:39:28 PST
Valgrind memcheck complains that TextRun::expantion() is uninitialized. http://code.google.com/p/chromium/issues/detail?id=115808#c5 TextRun::m_expansion is initialized by InlineBox::m_expansion to InlineTextBox::constructTextRun(), which is initialized to zero. After some investigation, I noticed that m_expansion doesn't align to a byte boundary. This caused the valgrind errors.
Attachments
Patch (1.36 KB, patch)
2012-02-28 00:50 PST, Kenichi Ishibashi 		no flags
DetailsFormatted DiffDiff
Patch for landing (1.41 KB, patch)
2012-02-29 03:07 PST, Kenichi Ishibashi 		no flags
DetailsFormatted DiffDiff
Show Obsolete (1) View All Add attachment proposed patch, testcase, etc.
Kenichi Ishibashi
Comment 1 2012-02-28 00:50:18 PST
Created attachment 129210 [details] Patch
Kenichi Ishibashi
Comment 2 2012-02-28 00:54:13 PST
(In reply to comment #1) > Created an attachment (id=129210) [details] > Patch I checked: - Valgrind memecheck doesn't detect uninitialized value references in HarfBuzzShaperBase. - The size of InlineBox is the same Morrita-san, could you please review?
Hajime Morrita
Comment 3 2012-02-29 01:43:05 PST
Comment on attachment 129210 [details] Patch Could you claim the fact about the sizeof(InlineBox) in ChangeLog?
Kenichi Ishibashi
Comment 4 2012-02-29 03:07:11 PST
Created attachment 129427 [details] Patch for landing
WebKit Review Bot
Comment 5 2012-02-29 09:07:10 PST
Comment on attachment 129427 [details] Patch for landing Clearing flags on attachment: 129427 Committed r109220: <http://trac.webkit.org/changeset/109220>
WebKit Review Bot
Comment 6 2012-02-29 09:07:15 PST
All reviewed patches have been landed. Closing bug.
Note You need to log in before you can comment on or make changes to this bug.