Summary: | [Forms] Spin button sometimes ignores Indeterminate of m_upDownState | ||||||||||
---|---|---|---|---|---|---|---|---|---|---|---|
Product: | WebKit | Reporter: | yosin | ||||||||
Component: | Forms | Assignee: | yosin | ||||||||
Status: | RESOLVED FIXED | ||||||||||
Severity: | Normal | CC: | tkent, webkit.review.bot | ||||||||
Priority: | P2 | ||||||||||
Version: | 528+ (Nightly build) | ||||||||||
Hardware: | Unspecified | ||||||||||
OS: | Unspecified | ||||||||||
Attachments: |
|
Description
yosin
2012-02-27 23:46:39 PST
Created attachment 129209 [details]
Patch 1
Comment on attachment 129209 [details] Patch 1 View in context: https://bugs.webkit.org/attachment.cgi?id=129209&action=review > Source/WebCore/html/shadow/TextControlInnerElements.cpp:-297 > - ASSERT(m_upDownState != Indeterminate); If you think this assertion should be removed, please write a reason in ChangeLog. > Source/WebCore/html/shadow/TextControlInnerElements.cpp:299 > + if (m_upDownState != Indeterminate) { > + input->stepUpFromRenderer(m_upDownState == Up ? 1 : -1); > + if (renderer()) Wrong indentation. Created attachment 129217 [details]
Patch 2
Comment on attachment 129217 [details] Patch 2 View in context: https://bugs.webkit.org/attachment.cgi?id=129217&action=review > Source/WebCore/ChangeLog:14 > + m_upDownState can be Indeterminate at mousedown event if mouse pointer is on > + spin button when it is displayed. > + > + Reviewed by NOBODY (OOPS!). > + > + No new tests. No behavior change. This patch changes a behavior, and it seems you know how to reproduce the behavior change. Please write a test. Also, usual position of "Reviewed by .." line is just after the bug URL, before the long description. Created attachment 129369 [details]
Patch 3
Comment on attachment 129369 [details]
Patch 3
Looks good. Thanks!
Comment on attachment 129369 [details] Patch 3 Clearing flags on attachment: 129369 Committed r109193: <http://trac.webkit.org/changeset/109193> All reviewed patches have been landed. Closing bug. |