Bug 79748 – [Chromium] We should reset mouse position before calling eventSender.mouseMove in LayoutTest

• Component: Tools / Tests
• Status: RESOLVED FIXED

It seems flaky layout tests in fast/forms/number sometimes didn't receive mouse move event. This may be the root cause of flaky.
I update following tests adding reset mouse position before sending mouse move event.
 * input-number-events.html
 * input-number-large-padding.html
 * input-spinbutton-capturing.html
I'm not sure this update remove flake. But, I believe it is worth to try and make out test robust.
If this update won't fix flaky, I'll seek another for root of flaky.

Created attachment 129198 [details]
Patch 1

[Kent Tamura]

Comment on attachment 129198 [details]
Patch 1

View in context: https://bugs.webkit.org/attachment.cgi?id=129198&action=review

> LayoutTests/platform/chromium/test_expectations.txt:2154
> -BUGCR54330 MAC : fast/forms/number/input-spinbutton-capturing.html = PASS TEXT
> -BUGCR54331 MAC : fast/forms/number/input-number-events.html = PASS TEXT
>  

We're not sure that mouse pointer position is the root cause of the flakiness yet.  So do not remove these lines.

> LayoutTests/platform/chromium/test_expectations.txt:-3340
> -BUGWK70298 WIN LINUX : fast/forms/number/input-number-events.html = TEXT PASS
> -BUGWK70298 : fast/forms/number/input-number-large-padding.html = TEXT PASS
> -BUGWK70298 WIN LINUX : fast/forms/number/input-spinbutton-capturing.html = TEXT PASS

ditto.

Created attachment 129208 [details]
Patch 2

[Kent Tamura]

Comment on attachment 129208 [details]
Patch 2

ok.
Let's land this and see the flakiness dashboard.

[WebKit Review Bot]

The commit-queue encountered the following flaky tests while processing attachment 129208 [details]:

css3/filters/effect-invert-hw.html bug 79639 (author: [e-mail])
fast/files/file-reader-event-listener.html bug 79769 (author: [e-mail])
The commit-queue is continuing to process your patch.

[WebKit Review Bot]

Comment on attachment 129208 [details]
Patch 2

Clearing flags on attachment: 129208

Committed r109093: <http://trac.webkit.org/changeset/109093>

[WebKit Review Bot]

All reviewed patches have been landed.  Closing bug.

[Kent Tamura]

Ok, they look really stable after r109093.  I'll remove the flakiness expectation from test_expectations.txt.

[Kent Tamura]

  (In reply to comment #8)
> Ok, they look really stable after r109093.  I'll remove the flakiness expectation from test_expectations.txt.

Done: http://trac.webkit.org/changeset/109692