Bug 79744

Summary: kCTFontTableOptionExcludeSynthetic is unneeded
Product: WebKit Reporter: Ned Holbrook <ned>
Component: TextAssignee: Nobody <webkit-unassigned>
Severity: Enhancement CC: ap, mitz, webkit.review.bot
Priority: P2    
Version: 528+ (Nightly build)   
Hardware: Mac   
OS: OS X 10.6   
Description Flags
Proposed changes. none

Description Ned Holbrook 2012-02-27 21:59:39 PST
fontHasVerticalGlyphs() in SimpleFontDataMac.mm passes kCTFontTableOptionExcludeSynthetic to CTFontCopyAvailableTables(), but there is no need to do so (the option only affects 10.5-linked apps).
Comment 1 Ned Holbrook 2012-02-27 22:16:59 PST
Comment 2 Ned Holbrook 2012-02-27 22:19:24 PST
Created attachment 129188 [details]
Proposed changes.
Comment 3 WebKit Review Bot 2012-02-27 22:49:35 PST
Comment on attachment 129188 [details]
Proposed changes.

Clearing flags on attachment: 129188

Committed r109080: <http://trac.webkit.org/changeset/109080>
Comment 4 WebKit Review Bot 2012-02-27 22:49:40 PST
All reviewed patches have been landed.  Closing bug.
Comment 5 Alexey Proskuryakov 2012-02-28 13:01:24 PST
This is surprising. Doesn't WebKit need to support 10.5-linked applications?
Comment 6 Ned Holbrook 2012-02-28 14:03:41 PST
I learn something new every day. Does WebKit support vertical text on 10.5?