Bug 79744

Summary:

kCTFontTableOptionExcludeSynthetic is unneeded

Product:

WebKit

Reporter:

Ned Holbrook <ned>

Component:

Text

Assignee:

Nobody <webkit-unassigned>

Status:

RESOLVED FIXED

Severity:

Enhancement

CC:

ap, mitz, webkit.review.bot

Priority:

Version:

528+ (Nightly build)

Hardware:

Mac

OS:

OS X 10.6

Attachments:

Description	Flags
Proposed changes.	none

Ned Holbrook

Reported 2012-02-27 21:59:39 PST

fontHasVerticalGlyphs() in SimpleFontDataMac.mm passes kCTFontTableOptionExcludeSynthetic to CTFontCopyAvailableTables(), but there is no need to do so (the option only affects 10.5-linked apps).

Attachments
Proposed changes. (1.76 KB, patch) 2012-02-27 22:19 PST, Ned Holbrook	no flags	Details Formatted Diff Diff
View All Add attachment proposed patch, testcase, etc.

Ned Holbrook

Comment 1 2012-02-27 22:16:59 PST

<rdar://problem/10940932>

Ned Holbrook

Comment 2 2012-02-27 22:19:24 PST

Created attachment 129188 [details] Proposed changes.

WebKit Review Bot

Comment 3 2012-02-27 22:49:35 PST

Comment on attachment 129188 [details] Proposed changes. Clearing flags on attachment: 129188 Committed r109080: <http://trac.webkit.org/changeset/109080>

WebKit Review Bot

Comment 4 2012-02-27 22:49:40 PST

All reviewed patches have been landed. Closing bug.

Alexey Proskuryakov

Comment 5 2012-02-28 13:01:24 PST

This is surprising. Doesn't WebKit need to support 10.5-linked applications?

Ned Holbrook

Comment 6 2012-02-28 14:03:41 PST

I learn something new every day. Does WebKit support vertical text on 10.5?

Note You need to log in before you can comment on or make changes to this bug.