Summary: | REGRESSION(r109016): TransparencyWin unit tests failing on Chromium | ||
---|---|---|---|
Product: | WebKit | Reporter: | Adrienne Walker <enne> |
Component: | WebCore Misc. | Assignee: | Brett Wilson (Google) <brettw> |
Status: | RESOLVED FIXED | ||
Severity: | Normal | CC: | adamk, bashi, enne, mdelaney7, mitz |
Priority: | P2 | ||
Version: | 528+ (Nightly build) | ||
Hardware: | Unspecified | ||
OS: | Unspecified |
Description
Adrienne Walker
2012-02-27 17:02:37 PST
Committed r109043: <http://trac.webkit.org/changeset/109043> http://build.chromium.org/p/chromium.webkit/builders/Win%20%28dbg%29/builds/5186 I committed r109071 to fix compile errors. http://trac.webkit.org/changeset/109071 http://build.chromium.org/p/chromium.webkit/builders/Webkit%20Win%20%28dbg%29%281%29/builds/10511/steps/webkit_unit_tests/logs/stdio Further suppression added: http://trac.webkit.org/changeset/109077 Looks like DRT crashed or hanged. I think it's not safe to roll r109016 and later. I'm not familiar with these code so I couldn't handle the failures. Aha, I think this is probably a simple problem in the tests. They construct ImageBuffers like so: ImageBuffer::create(IntSize(16, 16), ColorSpaceDeviceRGB) But now the second argument is the scale. I'm going to try a speculative fix of adding the scale argument and re-enabling. (In reply to comment #4) > Aha, I think this is probably a simple problem in the tests. They construct ImageBuffers like so: > > ImageBuffer::create(IntSize(16, 16), ColorSpaceDeviceRGB) > > But now the second argument is the scale. I'm going to try a speculative fix of adding the scale argument and re-enabling. Speculatively fixed in http://trac.webkit.org/changeset/109119, waiting for bots to cycle before declaring victory. |