Bug 79715

Summary: FileReader crashes when file is not readable
Product: WebKit Reporter: Alexey Proskuryakov <ap>
Component: WebCore Misc.Assignee: Alexey Proskuryakov <ap>
Status: RESOLVED FIXED    
Severity: Normal CC: dimich, jianli, webkit.review.bot
Priority: P2    
Version: 528+ (Nightly build)   
Hardware: Unspecified   
OS: Unspecified   
Attachments:
Description Flags
poposed fix
none
patch with test none

Alexey Proskuryakov
Reported 2012-02-27 16:38:50 PST
E.g. if there's no permission, or it's a directory.
Attachments
poposed fix (4.18 KB, patch)
2012-02-27 17:31 PST, Alexey Proskuryakov 		no flags
DetailsFormatted DiffDiff
patch with test (6.88 KB, patch)
2012-02-28 10:43 PST, Alexey Proskuryakov 		no flags
DetailsFormatted DiffDiff
Show Obsolete (1) View All Add attachment proposed patch, testcase, etc.
Alexey Proskuryakov
Comment 1 2012-02-27 17:31:04 PST
Created attachment 129145 [details] poposed fix
Jian Li
Comment 2 2012-02-27 17:36:47 PST
Thanks for catching and fixing this. Is it possible to add a test for this?
Alexey Proskuryakov
Comment 3 2012-02-27 17:38:30 PST
I don't see how to add a test. I don't think that there is an unreadable file to count on.
Jian Li
Comment 4 2012-02-27 18:08:12 PST
We can pass a directory to eventSender.beginDragWithFiles. To test the case that there's no permission, it will require quite a bit of work. We can have a perl/python script to create a temporary file, revoke its read permission and then pass it to eventSender.beginDragWithFiles (see send-sliced-dragged-file.js that uses this technique to modify the temp file). How do you think?
Alexey Proskuryakov
Comment 5 2012-02-28 10:43:12 PST
Created attachment 129289 [details] patch with test Good idea.
WebKit Review Bot
Comment 6 2012-02-28 11:50:12 PST
Comment on attachment 129289 [details] patch with test Clearing flags on attachment: 129289 Committed r109132: <http://trac.webkit.org/changeset/109132>
WebKit Review Bot
Comment 7 2012-02-28 11:50:16 PST
All reviewed patches have been landed. Closing bug.
Note You need to log in before you can comment on or make changes to this bug.