Summary: | FileReader crashes when file is not readable | ||||||||
---|---|---|---|---|---|---|---|---|---|
Product: | WebKit | Reporter: | Alexey Proskuryakov <ap> | ||||||
Component: | WebCore Misc. | Assignee: | Alexey Proskuryakov <ap> | ||||||
Status: | RESOLVED FIXED | ||||||||
Severity: | Normal | CC: | dimich, jianli, webkit.review.bot | ||||||
Priority: | P2 | ||||||||
Version: | 528+ (Nightly build) | ||||||||
Hardware: | Unspecified | ||||||||
OS: | Unspecified | ||||||||
Attachments: |
|
Description
Alexey Proskuryakov
2012-02-27 16:38:50 PST
Created attachment 129145 [details]
poposed fix
Thanks for catching and fixing this. Is it possible to add a test for this? I don't see how to add a test. I don't think that there is an unreadable file to count on. We can pass a directory to eventSender.beginDragWithFiles. To test the case that there's no permission, it will require quite a bit of work. We can have a perl/python script to create a temporary file, revoke its read permission and then pass it to eventSender.beginDragWithFiles (see send-sliced-dragged-file.js that uses this technique to modify the temp file). How do you think? Created attachment 129289 [details]
patch with test
Good idea.
Comment on attachment 129289 [details] patch with test Clearing flags on attachment: 129289 Committed r109132: <http://trac.webkit.org/changeset/109132> All reviewed patches have been landed. Closing bug. |